Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings tabs- add scrolling and work without DEV_NOISY #1087

Merged
merged 2 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 60 additions & 57 deletions lib/platform-bible-react/dist/index.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/platform-bible-react/dist/index.cjs.map

Large diffs are not rendered by default.

119 changes: 61 additions & 58 deletions lib/platform-bible-react/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/platform-bible-react/dist/index.js.map

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function NavigationContentSearch({
}: NavigationContentSearchProps) {
return (
<div className="pr-twp">
<div className="pr-space-y-2 pr-pb-2">
<div className="pr-sticky pr-top-0 pr-space-y-2 pr-pb-2">
{headerTitle ? <h1>{headerTitle}</h1> : ''}
<SearchBar
isFullWidth={isSearchBarFullWidth}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ export function SettingsListItem({
<div className="pr-flex pr-items-center pr-justify-between pr-space-x-4 pr-py-2">
<div>
<p className="pr-text-sm pr-font-medium pr-leading-none">{primary}</p>
<p className="pr-text-sm pr-text-muted-foreground">{secondary}</p>
<p className="pr-whitespace-normal pr-break-words pr-text-sm pr-text-muted-foreground">
{secondary}
</p>
</div>

{isLoading ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ if (globalThis.isNoisyDevModeEnabled) {
[TAB_TYPE_WEBVIEW, loadWebViewTab],
[TAB_TYPE_DOWNLOAD_UPDATE_PROJECT_DIALOG, loadDownloadUpdateProjectTab],
[TAB_TYPE_EXTENSION_MANAGER, loadExtensionManagerTab],
[TAB_TYPE_USER_SETTINGS_TAB, loadUserSettingsTab],
[TAB_TYPE_PROJECT_SETTINGS_TAB, loadProjectSettingsTab],
...Object.entries(DIALOGS).map(
([dialogTabType, dialogDefinition]) =>
// The default implementation of `loadDialog` uses `this`, so bind it to the definition
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.settings-tab {
padding: 2%;
padding: 0 2% 2%;
height: inherit;
overflow-y: auto;
}
Loading