Remove unused file #1105
Merged
Remove unused file #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in favor of #1103 - dependabot was confused because this file wasn't cleaned up when we moved to an npm workspace
irahopkinson
force-pushed
the
cleanup
branch
from
fafab02
to
21f64b8
Compare
tjcouch-sil
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
I thought we had decided already that we would leave package-lock.json in... but this is the only one I'm seeing for some reason. Maybe I am forgetting. Do you remember that conversation? I thought we decided to leave these in because it makes merging from the templates eaiser.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
|
IIRC we didn't agree. You thought it made merging easier - I thought removing them was just as easy for merging and suited the npm workspace better. Since then we have had various problems with the npm workspace which has resulting in people removing the unused lock files. As you say this is the last one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is