Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split papi.d.ts #251

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Split papi.d.ts #251

merged 1 commit into from
Jun 20, 2023

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Jun 20, 2023

This change is Reviewable

Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just one non-blocking comment.

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @irahopkinson)


lib/papi-dts/papi.d.ts line 1372 at r1 (raw file):

      createLocalObjectToProxy?: LocalObjectToProxyCreator<T> | undefined,
    ) => Promise<NetworkObject<T> | undefined>;
    set: <T_1 extends NetworkableObject<object>>(

It's weird that this changed. I assume it's benign, but I don't understand why this changed.

Copy link
Contributor Author

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @irahopkinson)


lib/papi-dts/papi.d.ts line 1372 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

It's weird that this changed. I assume it's benign, but I don't understand why this changed.

This got missed on someone's previous PR (maybe mine). If you got to main brnach and run npm run build:types it makes this one change.

@irahopkinson irahopkinson merged commit 6b5a007 into main Jun 20, 2023
@irahopkinson irahopkinson deleted the 172b-split-papi-dts branch June 20, 2023 22:14
@irahopkinson irahopkinson linked an issue Jun 20, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks for the great work on this :)

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split PAPI into 3 code modules and make user import from just one of them
3 participants