Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Add traces #3396

Merged
merged 5 commits into from
Jul 14, 2023
Merged

debuginfo: Add traces #3396

merged 5 commits into from
Jul 14, 2023

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Jul 5, 2023 •
edited
Loading

  • Extract tracer to its own package
  • Add a TracingBucket wrapper
  • Configure gRPC and HTTP clients propagate context
  • Upgrade FrostDB
  • Upgrade thanos-io/objstore

Signed-off-by: Kemal Akkoyun [email protected]

Test Plan

$ cd script/local-tracing && docker compose up -d
$ ./bin/parca --otlp-address=127.0.0.1:4317

CleanShot 2023-07-06 at 09 40 10

CleanShot 2023-07-13 at 16 04 58

xref: thanos-io/objstore#61
xref: polarsignals/frostdb#469

@kakkoyun kakkoyun requested a review from a team as a code owner July 5, 2023 15:58
@kakkoyun kakkoyun marked this pull request as draft July 5, 2023 15:59
@brancz brancz mentioned this pull request Jul 5, 2023
Closed
@kakkoyun kakkoyun marked this pull request as ready for review July 5, 2023 17:48
@kakkoyun kakkoyun requested review from a team as code owners July 5, 2023 17:48
kakkoyun
kakkoyun commented Jul 5, 2023
View reviewed changes
pkg/parca/parca.go Outdated
})
httpDebugInfoClient, err := debuginfo.NewHTTPDebuginfodClient(logger, flags.Debuginfod.UpstreamServers,
&http.Client{
Transport: otelhttp.NewTransport(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP GET error in the screenshot comes from here.

kakkoyun
kakkoyun commented Jul 5, 2023
View reviewed changes
pkg/debuginfo/debuginfod.go Outdated Show resolved Hide resolved
@kakkoyun kakkoyun requested a review from brancz July 5, 2023 17:56
@kakkoyun kakkoyun marked this pull request as draft July 5, 2023 18:16
@kakkoyun kakkoyun changed the title Extract tracer to its own package debuginfo: Add traces Jul 6, 2023
@kakkoyun kakkoyun marked this pull request as ready for review July 6, 2023 08:01
brancz
brancz reviewed Jul 6, 2023
View reviewed changes
pkg/objectstore/bucket.go Outdated Show resolved Hide resolved
brancz
brancz reviewed Jul 6, 2023
View reviewed changes
pkg/debuginfo/debuginfod.go Outdated Show resolved Hide resolved
@kakkoyun kakkoyun marked this pull request as draft July 6, 2023 12:10
@kakkoyun kakkoyun mentioned this pull request Jul 6, 2023
Merged
@kakkoyun
Extract tracer to its own package
d33b97a 
Add OpenTracing Bridge

Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
Add tracing bucket
bcc1257 
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
Upgrade objstore
26130d6 
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
Upgrade to latest APIs
93fd023 
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun kakkoyun marked this pull request as ready for review July 13, 2023 14:05
@kakkoyun kakkoyun merged commit d5a2e1a into main Jul 14, 2023
31 checks passed
@kakkoyun kakkoyun deleted the opentracing_bridge branch July 14, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@metalmatze metalmatze Awaiting requested review from metalmatze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakkoyun @brancz