Virtual routing fix (#224)

* run prettier * potential fix * fix relative paths * switch to last index to still support relative paths on legit assets * add test * fix failing test
parcel-bundler · Jan 3, 2018 · e09575d · e09575d
1 parent 50de97f
commit e09575d
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 0 deletions.
diff --git a/src/assets/HTMLAsset.js b/src/assets/HTMLAsset.js
@@ -42,6 +42,10 @@ class HTMLAsset extends Asset {
       if (node.attrs) {
         for (let attr in node.attrs) {
           let elements = ATTRS[attr];
+          // Check for virtual paths
+          if (node.tag === 'a' && node.attrs[attr].lastIndexOf('.') < 1) {
+            break;
+          }
           if (elements && elements.includes(node.tag)) {
             let assetPath = this.addURLDependency(node.attrs[attr]);
             if (!isURL(assetPath)) {

diff --git a/test/html.js b/test/html.js
@@ -172,6 +172,24 @@ describe('html', function() {
     assert(html.includes('<a href="#hash_link">'));
   });
 
+  it('Should detect virtual paths', async function() {
+    let b = await bundle(
+      __dirname + '/integration/html-virtualpath/index.html'
+    );
+
+    assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'html',
+          assets: ['other.html'],
+          childBundles: []
+        }
+      ]
+    });
+  });
+
   it('should not update root/main file in the bundles', async function() {
     await bundle(__dirname + '/integration/html-root/index.html');
 

diff --git a/test/integration/html-virtualpath/index.html b/test/integration/html-virtualpath/index.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<html>
+<head>
+  <title>Virtual path test</title>
+</head>
+<body>
+  <a href="/somewhere">Virtual path</a>
+  <a href="/some/other/route">Another virtual path</a>
+  <a href="./other.html">A real path</a>
+</body>
+</html>
diff --git a/test/integration/html-virtualpath/other.html b/test/integration/html-virtualpath/other.html
@@ -0,0 +1,9 @@
+<!doctype html>
+<html>
+<head>
+  <title>Virtual path test</title>
+</head>
+<body>
+  <h1>Other page</h1>
+</body>
+</html>