Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel attempts to rewrite remote URIs #12

Closed
adamhutch opened this issue Dec 5, 2017 · 6 comments
Closed

Parcel attempts to rewrite remote URIs #12

adamhutch opened this issue Dec 5, 2017 · 6 comments

Comments

@adamhutch
Copy link

adamhutch commented Dec 5, 2017

Thanks for this project man, super excited to try it all out!

Ran into an issue with trying to use an external stylesheet. Not sure if there's a way to override this behaviour somehow.

In my index.html file, I have remote references to some CDN fonts, one example would be:

  • https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css

When running my dev server, it attempts to rewrite this URL and appends the dev server URL to it:

Would be great if the loader would ignore remote URLs.

@devongovett
Copy link
Member

it should ignore them. looks like maybe your url is missing a slash after https:/?

@adamhutch
Copy link
Author

adamhutch commented Dec 5, 2017

Woops, that's just how it outputs. I copied it twice.

Source:
image

Converts to this:

Output:
image

@mikeabraham
Copy link

Agreed. Awesome project. Very excited about it.

I have the same issue.

Source
<script src="https://unpkg.com/vue"></script>

Output
<script src="/dist/https:/unpkg.com/vue"></script>

@devongovett
Copy link
Member

devongovett commented Dec 6, 2017

Should be fixed by #22. Will go out in the next release.

@devongovett
Copy link
Member

Released in v1.0.2.

@adamhutch
Copy link
Author

Thanks so much @devongovett, confirmed fixed. Really appreciate the fast fix 👍

shawwn pushed a commit to shawwn/parcel that referenced this issue Jan 5, 2018
@SourceBoy SourceBoy mentioned this issue Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants