-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Dev, background image URIs are missing enclosed quotes #7556
Comments
Possible regression in 2.2.0 |
I was able to fix this by reverting to 2.1.1, so it would seem that way |
Same here, if I manually add double-quotes in compiled CSS it starts working again. Probably due to the new @parcel/css package that's being used now by default? |
Without a specification in I think a change in If I come up with a good idea about how to fix this issue, I'll send a PR, but I'd be also happy if someone else could do it. |
It seems currently not possible to pin parcel to a fixed version. In my opinion this is something that needs to be addressed! Any thoughts on this? :) |
With this, it probably doesn't work (because you're not actually using 2.0.1 of Parcel but it has resolved to a newer version): "parcel": "^2.0.1", but this should: "parcel": "2.0.1",
"@parcel/transformer-sass": "2.0.1" |
Thats what I had, but in the package.js of @parcel/transformer-sass it has under dependencies ie |
🐛 bug report
In Development, css property background uri's are missing their enclosing " " causing chrome to report invalid property value.
🎛 Configuration (.babelrc, package.json, cli command)
No Babelrc in project root (never needed one before), using Parcel stock / provided / built-in
🤔 Expected Behavior
Property value output should be valid in inspector for background URI
😯 Current Behavior
Currently causes an invalid prop type and no longer renders the image in the DOM
💁 Possible Solution
🔦 Context
Spent two - three hours thinking I was doing something wrong syntax wise, package upgrade, etc. Even converted the scss file to a styled js file to make it show up. A soon as I added " data:... " to the inspected image, waalaa.
css =>
Should be noted I did not see this issue when doing a production build output.
When using the sass transformer, in the development mode, enclosing quotes for the data URI should not be stripped or converted. If so they should respect the browser standard.
💻 Code Sample
🌍 Your Environment
Also, I was trying to use 2.0.1 on Parcel and Sass Transformer and was forced through build error I had to use 2.2.0. Was not a huge fan of that. Outside of that, I love what parcel does for me on the regular. Thanks guys!
The text was updated successfully, but these errors were encountered: