Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #1271

Merged
merged 15 commits into from
May 1, 2018
Merged

Update deps #1271

merged 15 commits into from
May 1, 2018

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented May 1, 2018

This PR updates some dependencies to fix some node 10 issues, as well as update htmlnano, which got updated to have safe defaults. Therefore default config is removed.

Closes #1266

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #1271 into master will increase coverage by 2.69%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
+ Coverage   86.61%   89.31%   +2.69%     
==========================================
  Files          77       77              
  Lines        4033     4406     +373     
==========================================
+ Hits         3493     3935     +442     
+ Misses        540      471      -69
Impacted Files Coverage Δ
src/transforms/htmlnano.js 100% <100%> (+27.77%) ⬆️
src/assets/PugAsset.js 88.57% <0%> (-11.43%) ⬇️
src/assets/SASSAsset.js 90.16% <0%> (-6.62%) ⬇️
src/assets/LESSAsset.js 93.61% <0%> (-6.39%) ⬇️
src/utils/PromiseQueue.js 90.78% <0%> (-3.45%) ⬇️
src/utils/serializeObject.js 88.23% <0%> (-1.77%) ⬇️
src/assets/JSONAsset.js 92.3% <0%> (-1.03%) ⬇️
src/assets/VueAsset.js 86.66% <0%> (-0.84%) ⬇️
src/assets/GraphqlAsset.js 100% <0%> (ø) ⬆️
src/assets/YAMLAsset.js 100% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6912d...1a7dd52. Read the comment docs.

@devongovett devongovett merged commit ec98a95 into master May 1, 2018
@devongovett devongovett deleted the deps-update branch May 1, 2018 15:01
@ayush000
Copy link

ayush000 commented May 2, 2018

@devongovett Have you pushed these changes to npm? While trying to install parcel-bundler using yarn, I'm getting error that is supposed to be fixed in this commit.

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=4 <=9".
error Found incompatible module

devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel lockfile causing errors on Node.js v10
4 participants