Fix loading modules with AMD defines #1285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UMD modules like moment-timezone have their AMD check before the CommonJS one. When an AMD loader like RequireJS is on the page, this causes the module to call
define
instead of exposing the exports to Parcel via CommonJS.This PR sets
define
toundefined
inside modules so that the AMD check will not pass and the exports will be exposed to CommonJS instead.