Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for line counter #1444

Merged
merged 2 commits into from
May 27, 2018

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented May 27, 2018

I'm curious if not using require('os').EOL for splitting lines in lineCounter is problematic or not. Since I don't have a Windows machine I'm testing this in your CI! :D

@codecov-io
Copy link

codecov-io commented May 27, 2018

Codecov Report

Merging #1444 into master will increase coverage by 3.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1444     +/-   ##
=========================================
+ Coverage      87%   90.51%   +3.5%     
=========================================
  Files          80       80             
  Lines        4286     6133   +1847     
=========================================
+ Hits         3729     5551   +1822     
- Misses        557      582     +25
Impacted Files Coverage Δ
src/Logger.js 83.06% <0%> (-13.78%) ⬇️
src/packagers/CSSPackager.js 87.87% <0%> (-12.13%) ⬇️
src/assets/PugAsset.js 88.57% <0%> (-11.43%) ⬇️
src/assets/JSONAsset.js 84.61% <0%> (-8.72%) ⬇️
src/utils/getRootDir.js 86.11% <0%> (-8.34%) ⬇️
src/worker.js 92.1% <0%> (-7.9%) ⬇️
src/HMRServer.js 85% <0%> (-6.67%) ⬇️
src/Bundle.js 93.05% <0%> (-6.2%) ⬇️
src/packagers/JSPackager.js 82.74% <0%> (-5.83%) ⬇️
src/Pipeline.js 93.06% <0%> (-4.89%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e04b5...582452e. Read the comment docs.

@DeMoorJasper
Copy link
Member

Wait what is codecov just not working properly?
This should increase test coverage right?

@mohsen1
Copy link
Contributor Author

mohsen1 commented May 27, 2018

my bad. I left the .only there :(

Suggestion: Your lint rules should be a bit stricter as this project grows.

@DeMoorJasper DeMoorJasper merged commit dc11325 into parcel-bundler:master May 27, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
I'm curious if not using `require('os').EOL` for splitting lines in lineCounter is problematic or not. Since I don't have a Windows machine I'm testing this in your CI! :D
devongovett pushed a commit that referenced this pull request Oct 15, 2018
I'm curious if not using `require('os').EOL` for splitting lines in lineCounter is problematic or not. Since I don't have a Windows machine I'm testing this in your CI! :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants