Fix issue with duplicate ids #1803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spelling corrections
see following discussions: - #2010 (comment) - #2010 (comment) - #2010 (comment)
This was blocking me from using 1.10.beta0.
--- name: 🙋 fix for watch not working when NODE_ENV is 'production' about: fixes issue #2011 --- <!--- Thanks for filing a pull request 😄 ! Before you submit, please read the following: Search open/closed issues before submitting since someone might have pushed the same thing before! --> ## ↪️ Pull Request <!--- Provide a general summary of the pull request here Does this address an existing issue? --> I understand that Parcel should watch changes every time the watch command is being used. Previously, watch was enabled on dev environment only, while the watch command inserted by users was completely ignored. With this modification, watch is always enabled if the user passes the command in CLI. ## 💻 Examples There is an example in #2011 - first post ## ✔️ PR Todo - [ ] Added/updated unit tests for this change - [ ] Filled out test instructions - [ ] Included links to related issues/PRs <!-- Love parcel? Please consider supporting our collective: 👉 https://opencollective.com/parcel/donate -->
Knockout.js uses <script type="text/html> for named templates. Currently, the type attribute is stripped by parcel. This change prevents that from happening.
|
Due to move to monorepo which rewrote the git history, this PR was automatically closed. Please open a new PR against master with your changes. You can do a diff against the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although very unlikely it was possible to have duplicate ids.
This PR makes the bundler check for a duplicate and pick a new id if there is a duplicate.
Only necessary on production builds as development uses relative paths and scope hoisting minifies everything anyways