Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-libs-browser: require util^0.12.3 #4579

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

wbinnssmith
Copy link
Contributor

@wbinnssmith wbinnssmith commented May 6, 2020

This upgrades the minimum necessary version of util to 0.12.3, which has better support for IE 11: browserify/node-util#47

@height
Copy link

height bot commented May 6, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

You can also use "Close T-X" to automatically close a task when the pull request is merged.

@wbinnssmith
Copy link
Contributor Author

Update: ran yarn-deduplicate (https://github.com/atlassian/yarn-deduplicate) on the yarn.lock.

@parcel-benchmark
Copy link

parcel-benchmark commented May 7, 2020

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 6.40s +38.00ms
Cached 2.27s -19.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 242.00ms -18.00ms 🚀
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 242.00ms -18.00ms 🚀
dist/legacy/styles.afb8e31a.css 78.00b +0.00b 1.64s +312.00ms ⚠️
dist/modern/styles.cda8c91b.css 78.00b +0.00b 1.31s -198.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 294.00ms +106.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 293.00ms +105.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 9.59s +153.00ms
Cached 2.22s -80.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/main/index.js 66.80kb +0.00b 2.23s +121.00ms ⚠️
dist/module/index.js 37.47kb +0.00b 2.23s +120.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/main/index.js 66.80kb +0.00b 302.00ms +28.00ms ⚠️
dist/module/index.js 37.47kb +0.00b 299.00ms +35.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.92m -19.64s 🚀
Cached 5.21s +316.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/ak-editor.2a86fff7.js 2.50mb +2.53kb ⚠️ 1.63m +4.41s
dist/editorView.2ab50f4a.js 586.97kb +0.00b 1.56m -24.38s 🚀
dist/ak-editor.6766bda7.js 136.17kb +265.00b ⚠️ 18.39s -1.35s 🚀
dist/EmojiPickerComponent.d8e98777.js 98.99kb +0.00b 18.45s -1.28s 🚀
dist/Modal.4e0c06f1.js 41.63kb +0.00b 3.15s -1.10s 🚀
dist/component.8276bb5b.js 28.93kb +0.00b 8.18s +869.00ms ⚠️
dist/DatePicker.ccfecb85.js 21.58kb +0.00b 9.02s -6.98s 🚀
dist/clipboard.f2201fca.js 17.18kb +0.00b 1.64m +30.34s ⚠️
dist/workerHasher.ebf0b386.js 11.83kb +0.00b 13.80s -38.92s 🚀
dist/EmojiTypeAheadComponent.b1d18fae.js 9.28kb +0.00b 52.63s +30.91s ⚠️
dist/media-viewer.52d4959e.js 4.18kb +0.00b 35.16s +11.16s ⚠️
dist/16.cb2f1a3a.js 3.72kb +0.00b 3.15s -1.10s 🚀
dist/Modal.5955c887.js 3.50kb +0.00b 8.11s +802.00ms ⚠️
dist/EmojiUploadComponent.7cd6a990.js 2.50kb +0.00b 52.63s +31.81s ⚠️
dist/ResourcedEmojiComponent.8ea5609c.js 2.29kb +0.00b 8.11s +863.00ms ⚠️
dist/card.c002a0cc.js 2.19kb +0.00b 35.35s -2.55s 🚀
dist/media-picker-analytics-error-boundary.bd391930.js 1.84kb +0.00b 1.07m -3.70s 🚀
dist/feedback.d3363837.js 1.71kb +0.00b 9.00s +627.00ms ⚠️
dist/workerHasher.ac36166a.js 1.64kb +0.00b 13.80s -2.20s 🚀
dist/heading6.fec11280.js 1.38kb +0.00b 9.00s +628.00ms ⚠️
dist/heading3.204cb980.js 1.36kb +0.00b 10.13s +1.83s ⚠️
dist/16.e32aa49c.js 1.34kb +0.00b 3.15s -1.10s 🚀
dist/media-card-analytics-error-boundary.65fd9d6a.js 1.30kb +0.00b 1.04m +21.45s ⚠️
dist/16.1dbb5df4.js 1.28kb +0.00b 3.15s -1.10s 🚀
dist/Modal.6509cbe3.js 1.26kb +0.00b 8.25s +2.13s ⚠️
dist/heading5.9d7bec75.js 1.25kb +0.00b 9.00s +634.00ms ⚠️
dist/16.ceac57cd.js 1.25kb +0.00b 7.39s -1.93s 🚀
dist/16.35be54a4.js 1.23kb +0.00b 7.17s -2.05s 🚀
dist/16.6be9bbc8.js 1.23kb +0.00b 7.39s -1.93s 🚀
dist/16.9015e8cf.js 1.23kb +0.00b 6.97s -1.74s 🚀
dist/16.234ee133.js 1.23kb +0.00b 3.15s -1.10s 🚀
dist/expand.c08c17cb.js 1.23kb +0.00b 9.00s -6.34s 🚀
dist/heading4.bc549c46.js 1.14kb +0.00b 10.22s +1.85s ⚠️
dist/panel-warning.36e3f1a9.js 1.06kb +0.00b 9.64s +1.57s ⚠️
dist/panel.32d95efd.js 972.00b +0.00b 9.67s +1.59s ⚠️
dist/media-viewer-analytics-error-boundary.03d32605.js 913.00b +0.00b 35.16s +11.10s ⚠️
dist/simpleHasher.dd9d4306.js 609.00b +0.00b 13.80s -39.48s 🚀
dist/index.html 219.00b +0.00b 953.00ms -5.01s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/ak-editor.2a86fff7.js 2.50mb +2.53kb ⚠️ 588.00ms -12.00ms
dist/ak-editor.6766bda7.js 136.17kb +265.00b ⚠️ 584.00ms -14.00ms

Three.js x4 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/util-0.12.3 branch 2 times, most recently from 7d45256 to ad911c4 Compare May 7, 2020 02:03
@wbinnssmith wbinnssmith merged commit 52f0cbb into v2 May 7, 2020
@mischnic mischnic deleted the wbinnssmith/util-0.12.3 branch May 7, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants