Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extension packaging work #8730

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Make extension packaging work #8730

merged 2 commits into from
Jan 6, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Dec 31, 2022

This makes the packaged extension actually work (bundles the extension "client" and the server together separately into two bundles, then the result is zipped by vsce into a vsix file)

  • Packaging & manually installing the extension from the bundle
  • Publishing Let's do that later separately, let's first add all features I have in the pipeline before publishing

Because we are using @parcel/watcher, the extension will only work on platforms with prebuilds (macOS Intel+Arm, Windows x64, Linux x64). So maybe we should just use Node's fs.watch...

Bildschirm­foto 2022-12-31 um 13 04 19

@parcel-benchmark
Copy link

parcel-benchmark commented Dec 31, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.39s -3.00ms
Cached 313.00ms +7.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 8.89s +38.00ms
Cached 413.00ms -7.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.46m -468.00ms
Cached 2.02s +56.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.55s +80.00ms
Cached 255.00ms +14.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic force-pushed the vscode-packaging branch 2 times, most recently from 717790c to 9ded810 Compare January 3, 2023 19:28
Base automatically changed from lsp-refactor to v2 January 4, 2023 20:20
@mischnic mischnic marked this pull request as ready for review January 4, 2023 21:45
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2017-present Devon Govett
Copy link
Member

@devongovett devongovett Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we should probably change this to "Parcel Contributors" or something at some point. Not exactly sure how that works from a legal standpoint though.

@mischnic mischnic merged commit e21af59 into v2 Jan 6, 2023
@mischnic mischnic deleted the vscode-packaging branch January 6, 2023 20:37
marcins pushed a commit to marcins/parcel that referenced this pull request Jul 14, 2023
* upstream/v2: (33 commits)
  v2.8.3
  Changelog for v2.8.3
  Address bug by updating an asset reference and merge conditions (parcel-bundler#8762)
  Fix CSS order when merging type change bundles (parcel-bundler#8766)
  fixing failing build for contributors on Linux using Node 18 (parcel-bundler#8763)
  Extension: Importers View and separate LSP protocol package (parcel-bundler#8747)
  Bump swc to fix sourcemaps with Windows line endings (parcel-bundler#8756)
  Apply HMR updates in topological order (parcel-bundler#8752)
  Make extension packaging work (parcel-bundler#8730)
  Typed api.storeResult (parcel-bundler#8732)
  Refactor LSP to use vscode-jsonrpc (parcel-bundler#8728)
  Bump swc (parcel-bundler#8742)
  Recursively check reachability when removing asset graphs from bundles in deduplication (parcel-bundler#6004)
  Fix tsc sourcemaps metadata (parcel-bundler#8734)
  Assigning to `this` in CommonJS (parcel-bundler#8737)
  Don't retarget dependencies if a symbol is imported multiple times with different local names (parcel-bundler#8738)
  Add a note about using flow in CONTRIBUTING.md (parcel-bundler#8731)
  filter out title execArgv to workers (parcel-bundler#8719)
  Document more of the BundleGraph class (parcel-bundler#8711)
  Fixed the hmr connection with host 0.0.0.0 (parcel-bundler#7357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants