Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property descriptor of config.internal in transforms/babel.js #880

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Fix property descriptor of config.internal in transforms/babel.js #880

merged 2 commits into from
Feb 24, 2018

Conversation

dalcib
Copy link
Contributor

@dalcib dalcib commented Feb 22, 2018

The default descriptor for 'configurable'is false, which causes the error Cannot delete property 'internal' of #<Object>
I am developing a plugin (https://github.com/dalcib/parcel-plugin-react-native-web) and found this error.

The default descriptor for 'configurable'is `false`, which causes the error `Cannot delete property 'internal' of #<Object>`
@codecov-io
Copy link

Codecov Report

Merging #880 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
+ Coverage   88.77%   89.21%   +0.43%     
==========================================
  Files          68       68              
  Lines        3440     3440              
==========================================
+ Hits         3054     3069      +15     
+ Misses        386      371      -15
Impacted Files Coverage Δ
src/transforms/babel.js 94.17% <100%> (ø) ⬆️
src/assets/StylusAsset.js 70.88% <0%> (-12.66%) ⬇️
src/utils/config.js 86.95% <0%> (-1.45%) ⬇️
src/visitors/dependencies.js 83.11% <0%> (+1.29%) ⬆️
src/assets/CSSAsset.js 83.47% <0%> (+1.73%) ⬆️
src/visitors/fs.js 73.61% <0%> (+15.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c38e5...27a09c6. Read the comment docs.

@devongovett devongovett merged commit eaf51d0 into parcel-bundler:master Feb 24, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
* Fix property descriptor of config.internal in transforms/babel.js

The default descriptor for 'configurable'is `false`, which causes the error `Cannot delete property 'internal' of #<Object>`

* Formatting
devongovett pushed a commit that referenced this pull request Oct 15, 2018
* Fix property descriptor of config.internal in transforms/babel.js

The default descriptor for 'configurable'is `false`, which causes the error `Cannot delete property 'internal' of #<Object>`

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants