Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Auto-Fetch parity on first run #79

Merged
merged 22 commits into from
Apr 30, 2018
Merged

Auto-Fetch parity on first run #79

merged 22 commits into from
Apr 30, 2018

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Apr 26, 2018

The behavior is:

  • if an instance of parity is running, run UI normally
  • if not, then fetch latest version of parity (as per vanity-service) and put it in the Application data folder (so not in PATH). A progress bar is shown during this step. The UI will then run parity in the bg once installed.
  • all --flags passed to Parity UI will be passed down to parity

Closes #57
Closes #65

@amaury1093 amaury1093 added the A3-inprogress Pull request is in progress. No review needed at this stage. label Apr 26, 2018
@amaury1093 amaury1093 changed the base branch from am-reorganize-files to next April 26, 2018 15:44
@amaury1093 amaury1093 added A0-pleasereview Pull request needs code review. and removed A3-inprogress Pull request is in progress. No review needed at this stage. labels Apr 27, 2018
@jacogr jacogr added the A8-looksgood Pull request is reviewed well. label Apr 30, 2018
@jacogr jacogr removed the A0-pleasereview Pull request needs code review. label Apr 30, 2018
@amaury1093 amaury1093 merged commit 00930bc into next Apr 30, 2018
@amaury1093 amaury1093 deleted the am-bundle-parity branch April 30, 2018 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants