This repository has been archived by the owner on Apr 11, 2022. It is now read-only.
fix(#344): make production serve work #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmespresso
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes comment in #344 (comment):
docker run nomidot-front:v0.5.0should just run the image at port 9000 now, no errors.main changes:
in Dockerfile:
added a
EXPOSE 9000becausegatsby develop(local env) exposes port 8000, butgatsby serve(staging & production) exposes port 9000added
yarn install --productiondoesn't install dev dependcies.added a
COPY ./public .so the build gets copied into the containerpushed the image to: eu.gcr.io/test-installations-222013/nomidot-front@sha256:f8d4983c94471b4b99d109f258e08aade5c4e5a8ada8cd5a55f2cba6246654c1