Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

CACHEPOT_BASEDIR #116

Merged
merged 6 commits into from
Dec 6, 2021
Merged

CACHEPOT_BASEDIR #116

merged 6 commits into from
Dec 6, 2021

Conversation

montekki
Copy link
Contributor

No description provided.

@montekki montekki marked this pull request as ready for review November 30, 2021 17:35
@montekki
Copy link
Contributor Author

@drahnr, marking this ready for review.

Just strip CARGO_MANIFEST_DIR from the paths, dont cache the cwd and call it a day. The testing i've done shows that it improves the cache hit rate somewhat but quite honestly I do not think that the task at hand is doable cleanly and safely for all usecases at this point.

Testing done: build cachepot with cachepot.

There still are a lot of absulute paths that end up in the build artifacts such as

  1. paths in *.d files.
  2. paths in artifacts from the cc builds
  3. paths in things that are still built locally such as cdylib crates.

src/compiler/rust.rs Outdated Show resolved Hide resolved
@drahnr
Copy link
Contributor

drahnr commented Dec 3, 2021

A rebase and this should be good to go :)

@drahnr
Copy link
Contributor

drahnr commented Dec 6, 2021

rustfmt seems unhappy, I'd like to land this soon™ :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants