This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
feat: misc server features #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for capi-multisig failed.
|
hamidra
reviewed
May 25, 2023
| @@ -0,0 +1,48 @@ | |||
| // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. | |||
There was a problem hiding this comment.
Are These codes ported from deno?:)
I'm wondering if They also publish them as npm package, so they can be added as dependencies?!
There was a problem hiding this comment.
Yeah i just copy and pasted them
There was a problem hiding this comment.
It can also be exported by Capi as a utility lib. I believe there is going to be a need for a library to provide some frequently used functionalities as utility. Not sure if Capi already provides such library.
e.g. PolkadotJS provides a utility and a utility-crypto lib which includes helpers to work with uint8Arrays and strings and address formatting, etc!
hamidra
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various server improvements