Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

refactor: workspaces + dprint + misc. #86

Merged
merged 19 commits into from
Mar 14, 2023
Merged

refactor: workspaces + dprint + misc. #86

merged 19 commits into from
Mar 14, 2023

Conversation

harrysolovay
Copy link
Contributor

@harrysolovay harrysolovay commented Mar 9, 2023 •
edited
Loading

  • updated use of project references so that we can share common utilities between the front-end and server code
  • updated tsconfig –– using newer modulekind allows us to use non-root exports from Capi (pattern libs) –– this requires .js in extensions (which is standard + desirable)
  • swapped out prettier with dprint, which is much faster, leaner and more configurable
  • fixed vite config issue
  • begin configuring trpc

New workflow in VSCode:

  • ⌘⇧P
  • Tasks: Run Task
  • watch

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for capi-multisig ready!

Name Link
🔨 Latest commit 0cdca20
🔍 Latest deploy log https://app.netlify.com/sites/capi-multisig/deploys/6410acafb0d43a0007d05686
😎 Deploy Preview https://deploy-preview-86--capi-multisig.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@harrysolovay
Copy link
Contributor Author

@statictype I'm unable to see the Netlify deployment logs. Can you please share the error message?

@statictype
Copy link
Contributor

statictype commented Mar 10, 2023 •
edited
Loading

the dist folder has a different path now. changing the path in Netlify breaks the other PRs. the deployment works fine otherwise.

@statictype statictype mentioned this pull request Mar 10, 2023
Closed
@harrysolovay harrysolovay marked this pull request as ready for review March 11, 2023 17:31
tukwan
tukwan reviewed Mar 13, 2023
View reviewed changes
www/package.json Outdated Show resolved Hide resolved
statictype
statictype previously approved these changes Mar 14, 2023
View reviewed changes
@statictype statictype merged commit cc5a44b into main Mar 14, 2023
@statictype statictype deleted the lots-of-refactoring branch March 14, 2023 17:22
@statictype statictype mentioned this pull request Mar 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tukwan tukwan tukwan left review comments

@statictype statictype statictype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrysolovay @statictype @tukwan