Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: improve bundle size #1070

Merged
merged 5 commits into from
Jun 15, 2023
Merged

feat: improve bundle size #1070

merged 5 commits into from
Jun 15, 2023

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Jun 14, 2023

Closes #1053 #1038

This PR improves

  • the bundle size for web
  • webpack configuration because externals["node:*"] is no longer required
  • vite configuration because build.rollupOptions.shimMissingExports is no longer required

Webpack Bundle Analyzer before and after this change

image

image

vite-bundle-visualizer after this change

image

mod.ts Outdated Show resolved Hide resolved
mod.ts Outdated Show resolved Hide resolved
Co-authored-by: T6 <[email protected]>
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this won't successfully merge until #1080 is merged

@kratico kratico enabled auto-merge June 15, 2023 14:59
@kratico kratico added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit 858e97e Jun 15, 2023
@kratico kratico deleted the feat/bundler-size branch June 15, 2023 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle size too large due to dev users
3 participants