This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: RPC-related Cleanup #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysolovay
commented
Jun 15, 2022
| @@ -2,14 +2,17 @@ import * as rpc from "../../../rpc/mod.ts"; | |||
| import { effector, EffectorArgs } from "../../impl/mod.ts"; | |||
|
|
|||
| export interface RpcClientR<Beacon> { | |||
| rpc: rpc.RpcClientFactory<Beacon>; | |||
| rpc: rpc.RpcClientFactory<Beacon, rpc.RpcError>; | |||
There was a problem hiding this comment.
Ignore the fact that we specify the wide rpc.RpcError instead of piping the error types through the top-level rpcClient effect. We'll get to this later (#46).
tjjfvi
reviewed
Jun 15, 2022
rpc/Base.ts
Outdated
|
|
||
| export abstract class RpcClient { | ||
| /** Send a message to the RPC server without |
| super(); | ||
| } | ||
| } | ||
| export abstract class RpcClient<RpcError extends E.RpcError> { |
There was a problem hiding this comment.
Why is this generic on the error?
There was a problem hiding this comment.
My thinking is that we'll want beacon-specific error types (web sockets can error out differently from Smoldot client instances).
tjjfvi
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.