This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: fix rpc message typings & clean up some tsdocs #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
reviewed
Jun 28, 2022
| @@ -6,7 +6,7 @@ export type DeriveCodec = (typeI: number) => $.Codec<unknown>; | |||
|
|
|||
| /** | |||
| * All derived codecs for ZSTs will use this exact codec, | |||
| * so `derivedCodec === $null` is true iff the type is a ZST. | |||
There was a problem hiding this comment.
This was not a typo – iff in logic is an abbreviation for "if and only if", which is the most accurate description of the contract of $null.
There was a problem hiding this comment.
Ahh, apologies
Comment on lines
+14
to
+16
| export type Flatten<T> = T extends (infer E)[] ? Flatten<E>[] | ||
| : T extends object ? { [K in keyof T]: Flatten<T[K]> } | ||
| : T; |
There was a problem hiding this comment.
This breaks Flatten for tuples. I've recently adopted
export type Flatten<T> = [{ [K in keyof T]: Flatten<T[K]> }][0]with the caveat that it should only be used to wrap things known to be simple objects or arrays
|
(the above posthumous review is here for convenience, and will be extracted later) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.