This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: beacon-related tweaks #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysolovay
commented
Jun 20, 2022
| @@ -7,7 +7,7 @@ import { rpcCall } from "./rpcCall.ts"; | |||
|
|
|||
| export const metadata = effector( | |||
| "metadata", | |||
| (rpc: EffectorItem<rpc.AnyClient>, blockHash?: EffectorItem<U.HashHexString>) => { | |||
| (rpc: EffectorItem<any>, blockHash?: EffectorItem<U.HashHexString>) => { | |||
There was a problem hiding this comment.
Effects are in need of a refactor, given the way that RPC types flow through the beacon into any/all calls. This any-ifying is temporary
harrysolovay
commented
Jun 20, 2022
| @@ -1,15 +1,3 @@ | |||
| import { Branded } from "../util/mod.ts"; | |||
There was a problem hiding this comment.
Proper branded types are still a todo.
harrysolovay
commented
Jun 20, 2022
| @@ -18,10 +18,10 @@ export type Subscription<NotificationResult = any> = { [_N]: NotificationResult | |||
|
|
|||
| export interface ClientProps< | |||
| M extends AnyMethods, | |||
| Beacon, | |||
| DiscoveryValue, | |||
There was a problem hiding this comment.
Zeroing in on correct terminology. Beacons contain discovery values (such as URLs and chain specs). Beacons are encoded with the type information necessary to constrain client usage.
harrysolovay
commented
Jun 20, 2022
| @@ -18,10 +18,10 @@ export type Subscription<NotificationResult = any> = { [_N]: NotificationResult | |||
|
|
|||
| export interface ClientProps< | |||
| M extends AnyMethods, | |||
| Beacon, | |||
| DiscoveryValue, | |||
There was a problem hiding this comment.
Zeroing in on correct terminology. Beacons contain discovery values (such as URLs and chain specs). Beacons are encoded with the type information necessary to constrain client usage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.