Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: improve MultisigRune.ratify #914

Merged
merged 4 commits into from
Apr 20, 2023
Merged

feat: improve MultisigRune.ratify #914

merged 4 commits into from
Apr 20, 2023

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Apr 19, 2023 •
edited
Loading

  • add nonExecuting to MultisigRune.ratify
  • remove MultisigRune.approve

@kratico kratico marked this pull request as ready for review April 19, 2023 15:43
harrysolovay
harrysolovay reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@harrysolovay harrysolovay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add some tsdoc comments to the members of VirtualMultisig?

EDIT:

Meant MultisigRune

@kratico
Copy link
Contributor Author

kratico commented Apr 19, 2023

Shall we add some tsdoc comments to the members of VirtualMultisig?

I need to get familiar with Proxies

Would it be ok to document VirtualMultisig in a separate PR?

@harrysolovay
Copy link
Contributor

@kratico apologies, I meant MultisigRune

@tjjfvi tjjfvi mentioned this pull request Apr 19, 2023
Closed
harrysolovay
harrysolovay suggested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@harrysolovay harrysolovay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The params of VirtualMultisigRune's ratify method should also change (ie. the addition of the nonExecuting param).

@kratico kratico added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 4610c88 Apr 20, 2023
@kratico kratico deleted the feat/multisig-ratify branch April 20, 2023 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harrysolovay harrysolovay harrysolovay approved these changes

@tjjfvi tjjfvi Awaiting requested review from tjjfvi

@ryanleecode ryanleecode Awaiting requested review from ryanleecode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kratico @harrysolovay