This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
suggested changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all the other codegen, we don't indent the template tags, e.g.
function foo() {
return `
console.log("Hello World")
`
}
Even though the code is formatted by dprint, it's nice for it to be less adhoc-ly indented before formatting. Can you update frameCodegen.ts
to follow this convention?
I think it helps with legibility. Certainly makes it easier for newcomers. |
Unlike the rest of our formatting, though, dprint doesn't handle it, and so the indentation can get out of sync with the surrounding code. |
tjjfvi
reviewed
Apr 21, 2023
Co-authored-by: T6 <[email protected]>
Co-authored-by: T6 <[email protected]>
Co-authored-by: T6 <[email protected]>
harrysolovay
force-pushed
the
rework-codegen
branch
from
April 21, 2023 20:18
55eb4c2
to
128ea26
Compare
tjjfvi
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #901