This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: raw metadata chain config + rename chain
#923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysolovay
changed the title
feat: raw metadata chain config
feat: raw metadata chain config + rename Apr 21, 2023
chain
harrysolovay
commented
Apr 22, 2023
harrysolovay
commented
Apr 25, 2023
harrysolovay
commented
Apr 25, 2023
harrysolovay
commented
Apr 25, 2023
harrysolovay
commented
Apr 25, 2023
tjjfvi
previously approved these changes
Apr 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 25, 2023
kratico
previously approved these changes
Apr 25, 2023
tjjfvi
reviewed
Apr 25, 2023
tjjfvi
approved these changes
Apr 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #621
Resolves #861
Resolves #927
chain
. This helps us forgo the excessive aliasing.Before:
After:
... then...
In this case, no chain instance is exposed, as one needs to construct it themselves.