Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

chore: fix deno workflow errors #944

Merged
merged 5 commits into from
Apr 29, 2023
Merged

chore: fix deno workflow errors #944

merged 5 commits into from
Apr 29, 2023

Conversation

ryanleecode
Copy link
Contributor

@ryanleecode ryanleecode commented Apr 28, 2023

Pins the deno version to 1.32.5 because 1.33 has introduced many breaking changing and we are unable to pinpoint whether workkflow errors are because of capi or because of a bug in the latest upgrade.

Added an issue to keep track of when we need to upgrade: #945

@ryanleecode ryanleecode changed the title chore: update deno to 1.33 chore: fix deno workflow errors Apr 28, 2023
_tasks/udd.ts Outdated Show resolved Hide resolved
_tasks/udd.ts Outdated Show resolved Hide resolved
deps/shims/command.node.ts Outdated Show resolved Hide resolved
deps/shims/Deno.node.ts Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
_tasks/udd.ts Outdated Show resolved Hide resolved
_tasks/udd.ts Outdated Show resolved Hide resolved
kratico
kratico previously approved these changes Apr 28, 2023
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ryanleecode ryanleecode added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@tjjfvi tjjfvi added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@harrysolovay harrysolovay added this pull request to the merge queue Apr 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2023
@harrysolovay harrysolovay added this pull request to the merge queue Apr 29, 2023
Merged via the queue into main with commit 0195725 Apr 29, 2023
@harrysolovay harrysolovay deleted the chore/update-deno-1.33 branch April 29, 2023 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants