Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix: enable runtime-benchmarks feature for xcm-builder #2173

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Feb 8, 2023

the change was included into master here #2159

@muharem muharem added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 8, 2023
@muharem
Copy link
Contributor Author

muharem commented Feb 9, 2023

PR to fix similar issue in cumulus paritytech/polkadot#6690

@muharem
Copy link
Contributor Author

muharem commented Feb 10, 2023

@coderobe @chevdor same here, with the patches paritytech/substrate#13348 and paritytech/polkadot#6690, I could run successfully all the benchmarks of runtimes locally on the current branch.
It also fixes the failing gitlab-check-runtime-benchmarks CI job.

@EgorPopelyaev
Copy link
Contributor

bot merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants