This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Nacho/improve xcm emulator v2 #2576
Merged
NachoPal
merged 62 commits into
ru/feature/xcm-emulator
from
nacho/improve-xcm-emulator-v2
May 18, 2023
Merged
Nacho/improve xcm emulator v2 #2576
NachoPal
merged 62 commits into
ru/feature/xcm-emulator
from
nacho/improve-xcm-emulator-v2
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* xcm remote lock config * rename * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
* bump zombienet version * fix para registration args
Co-authored-by: parity-processbot <>
* Import Clippy config from Polkadot Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Auto clippy fix Signed-off-by: Oliver Tale-Yazdi <[email protected]> * No tabs in comments Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Prefer matches Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Dont drop references Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Trivial Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Refactor Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fmt Signed-off-by: Oliver Tale-Yazdi <[email protected]> * add clippy to ci * Clippy reborrow Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update client/pov-recovery/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * Update client/pov-recovery/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * Partially revert 'Prefer matches' Using matches! instead of match does give less compiler checks as per review from @chevdor. Partially reverts 8c06096 Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update .cargo/config.toml Co-authored-by: Chevdor <[email protected]> * Revert revert 💩 Should be fine to use matches! macro since it is an explicit whitelist, not wildcard matching. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: alvicsam <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Chevdor <[email protected]> Co-authored-by: parity-processbot <>
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.160 to 1.0.162. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.160...1.0.162) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: parity-processbot <>
gilescope
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like the idea that we just use our own examples as there's less code to compile and maintain.
@NachoPal
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.