Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Xcm Emulator: prepare XCMP on init #2711

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Jun 8, 2023

The XCM messages are not passing between parachains right now, without manually calling init and reset before a test.
In the PR we preparing/opening the XCMP channels on a network initialization which happens once when execute_with invoke on any chain.
Calling just reset like in the examples here does not help, since static params like PARA_IDS are not initialized.

The PR also includes missing license headers for it tests.

@muharem muharem added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 8, 2023
@muharem muharem marked this pull request as ready for review June 8, 2023 08:43
@gilescope gilescope requested a review from NachoPal June 8, 2023 09:06
@gilescope
Copy link
Contributor

The other tests seem to work without needing to call prepare_for_xcmp. Does this fix just mean better emulation?

@muharem
Copy link
Contributor Author

muharem commented Jun 8, 2023

The other tests seem to work without needing to call prepare_for_xcmp. Does this fix just mean better emulation?

because for ump and dmp you don't need hrmp channels

@gilescope
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d5e33e4 into master Jun 8, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-xcm-emulator-network-init-fix branch June 8, 2023 11:09
NachoPal pushed a commit that referenced this pull request Jul 3, 2023
* std for pallet-glutton

* fix xcm-emulator init

* headers for it tests
NachoPal pushed a commit that referenced this pull request Jul 3, 2023
* std for pallet-glutton

* fix xcm-emulator init

* headers for it tests
paritytech-processbot bot pushed a commit that referenced this pull request Jul 3, 2023
* Xcm Emulator: prepare XCMP on init (#2711)

* std for pallet-glutton

* fix xcm-emulator init

* headers for it tests

* Fix for `xcm-emulator` - Wrong Parachain processing message (#2800)

* fix

* forgot para_id

* remove unreachable code

* remove glutton dep

---------

Co-authored-by: Muharem Ismailov <[email protected]>
paritytech-processbot bot pushed a commit that referenced this pull request Jul 3, 2023
* Xcm Emulator: prepare XCMP on init (#2711)

* std for pallet-glutton

* fix xcm-emulator init

* headers for it tests

* remove glutton dep

* Fix for `xcm-emulator` - Wrong Parachain processing message (#2800)

* fix

* forgot para_id

* remove unreachable code

---------

Co-authored-by: Muharem Ismailov <[email protected]>
girazoki pushed a commit to moondance-labs/cumulus that referenced this pull request Aug 11, 2023
…ritytech#2810)

* Xcm Emulator: prepare XCMP on init (paritytech#2711)

* std for pallet-glutton

* fix xcm-emulator init

* headers for it tests

* remove glutton dep

* Fix for `xcm-emulator` - Wrong Parachain processing message (paritytech#2800)

* fix

* forgot para_id

* remove unreachable code

---------

Co-authored-by: Muharem Ismailov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants