This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Xcm Emulator: prepare XCMP on init #2711
Merged
paritytech-processbot
merged 3 commits into
master
from
muharem-xcm-emulator-network-init-fix
Jun 8, 2023
Merged
Xcm Emulator: prepare XCMP on init #2711
paritytech-processbot
merged 3 commits into
master
from
muharem-xcm-emulator-network-init-fix
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
B0-silent
Changes should not be mentioned in any release notes
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Jun 8, 2023
The other tests seem to work without needing to call |
because for ump and dmp you don't need hrmp channels |
NachoPal
approved these changes
Jun 8, 2023
gilescope
approved these changes
Jun 8, 2023
bot merge |
paritytech-processbot
bot
deleted the
muharem-xcm-emulator-network-init-fix
branch
June 8, 2023 11:09
NachoPal
pushed a commit
that referenced
this pull request
Jul 3, 2023
* std for pallet-glutton * fix xcm-emulator init * headers for it tests
NachoPal
pushed a commit
that referenced
this pull request
Jul 3, 2023
* std for pallet-glutton * fix xcm-emulator init * headers for it tests
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Xcm Emulator: prepare XCMP on init (#2711) * std for pallet-glutton * fix xcm-emulator init * headers for it tests * Fix for `xcm-emulator` - Wrong Parachain processing message (#2800) * fix * forgot para_id * remove unreachable code * remove glutton dep --------- Co-authored-by: Muharem Ismailov <[email protected]>
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Xcm Emulator: prepare XCMP on init (#2711) * std for pallet-glutton * fix xcm-emulator init * headers for it tests * remove glutton dep * Fix for `xcm-emulator` - Wrong Parachain processing message (#2800) * fix * forgot para_id * remove unreachable code --------- Co-authored-by: Muharem Ismailov <[email protected]>
girazoki
pushed a commit
to moondance-labs/cumulus
that referenced
this pull request
Aug 11, 2023
…ritytech#2810) * Xcm Emulator: prepare XCMP on init (paritytech#2711) * std for pallet-glutton * fix xcm-emulator init * headers for it tests * remove glutton dep * Fix for `xcm-emulator` - Wrong Parachain processing message (paritytech#2800) * fix * forgot para_id * remove unreachable code --------- Co-authored-by: Muharem Ismailov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XCM messages are not passing between parachains right now, without manually calling
init
andreset
before a test.In the PR we preparing/opening the XCMP channels on a network initialization which happens once when
execute_with
invoke on any chain.Calling just
reset
like in the examples here does not help, since static params like PARA_IDS are not initialized.The PR also includes missing license headers for it tests.