Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version. #608

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Bump version. #608

merged 1 commit into from
Jan 20, 2021

Conversation

tomusdrw
Copy link
Contributor

Related #607

@tomusdrw tomusdrw requested a review from Xanewok January 19, 2021 21:51
niklasad1
niklasad1 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xanewok
Xanewok reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Do we want to address #605 as well before cutting the new release?

@tomusdrw
Copy link
Contributor Author

Looks good, thanks! Do we want to address #605 as well before cutting the new release?

@Xanewok your call. IMHO better to do it separately, and see if we run into any regressions without soketto, perhaps #605 could be implemented without an API change so it would be transparent to the users.

@Xanewok
Copy link
Contributor

Xanewok commented Jan 20, 2021

@tomusdrw Makes sense, let's do that separately. Deploy away! 🚀

@tomusdrw tomusdrw merged commit f418030 into master Jan 20, 2021
@tomusdrw tomusdrw deleted the td-bump branch January 20, 2021 10:56
This was referenced Mar 12, 2021
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@Xanewok Xanewok Xanewok approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @Xanewok @dvdplm @niklasad1