Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when unsubscribing from invalid subscription id #619

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented Mar 9, 2021

Problem

When processing a pubsub unsubscribe request, the unsubscribe callback is called even if there was no active subscription for that id.

Changes

  • Return an error for invalid unsubscribe requests
  • Don't call unsubscribe callback for invalid unsubscribes

cc @tomusdrw

Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@jstarry
Copy link
Contributor Author

jstarry commented Mar 9, 2021

No problem, thanks for the quick review! Do you think this could get released today? I'd like to get the fix in asap, but can build off a fork if needed. Cheers!

@jstarry
Copy link
Contributor Author

jstarry commented Mar 31, 2021

Hey @tomusdrw! Just a friendly ping about getting this out into a new release 😄

@tomusdrw tomusdrw merged commit 014b1ec into paritytech:master Mar 31, 2021
@tomusdrw tomusdrw mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants