Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap confirmation and finality transactions into batch_all in Millau -> RialtoParachain bridge #1898

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Wrap confirmation and finality transactions into batch_all in Millau -> RialtoParachain bridge #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab25fdb
wrap confirmation and finality transactions into batch_all in RialtoP…
svyatonik Feb 21, 2023
d8dc59a
review comments
svyatonik Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions relays/bin-substrate/src/chains/millau_messages_to_rialto_parachain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@

use relay_millau_client::Millau;
use relay_rialto_parachain_client::RialtoParachain;
use substrate_relay_helper::messages_lane::{
DirectReceiveMessagesDeliveryProofCallBuilder, SubstrateMessageLane,
use substrate_relay_helper::{
messages_lane::{DirectReceiveMessagesDeliveryProofCallBuilder, SubstrateMessageLane},
UtilityPalletBatchCallBuilder,
};

substrate_relay_helper::generate_receive_message_proof_call_builder!(
Expand All @@ -45,6 +46,6 @@ impl SubstrateMessageLane for MillauMessagesToRialtoParachain {
millau_runtime::WithRialtoParachainMessagesInstance,
>;

type SourceBatchCallBuilder = ();
type SourceBatchCallBuilder = UtilityPalletBatchCallBuilder<Millau>;
type TargetBatchCallBuilder = ();
}
13 changes: 5 additions & 8 deletions relays/messages/src/message_race_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,17 +573,14 @@ pub async fn run<P: MessageRace, SC: SourceClient<P>, TC: TargetClient<P>>(
if let Some((at_block, nonces_range, proof)) = race_state.nonces_to_submit.as_ref() {
log::debug!(
target: "bridge",
"Going to submit proof of messages in range {:?} to {} node",
"Going to submit proof of messages in range {:?} to {} node{}",
nonces_range,
P::target_name(),
target_batch_transaction.as_ref().map(|tx| format!(
". This transaction is batched with sending the proof for header {:?}.",
tx.required_header_id())
).unwrap_or_default(),
);
if let Some(ref target_batch_transaction) = target_batch_transaction {
log::debug!(
target: "bridge",
"This transaction is batched with sending the proof for header {:?}.",
target_batch_transaction.required_header_id(),
);
}

target_submit_proof.set(
race_target
Expand Down