-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcm-emulator] Make a generic constructor method for genesis Storage
#2613
Labels
Comments
0xmovses
added
I4-refactor
Code needs refactoring.
T10-tests
This PR/Issue is related to tests.
labels
Dec 4, 2023
0xmovses
changed the title
[xcm-emulator] Make a generic
[xcm-emulator] Make a generic constructor method for genesis Dec 4, 2023
genesis
constructor methodStorage
bkontur
pushed a commit
that referenced
this issue
Jun 5, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 7, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 7, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 12, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 13, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 14, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 14, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 14, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 14, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 20, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 20, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 26, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 26, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jun 28, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jul 1, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jul 4, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jul 16, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
bkontur
pushed a commit
that referenced
this issue
Jul 17, 2024
* report expected reward from target to source chain in confirmation transaction * added tests for new code * fix benchmarks compilation * clippy + spelling * remove extra requirements * RewardAtSource -> RelayerRewardAtSource, delivery_reward_per_message -> relayer_reward_per_message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Currently we write a separate
genesis
function for each Parachain when creating the emulated test environmentscumulus/parachains/integration-tests/emulated/chains/parachains/bridges/bridge-hub-rococo/src/genesis.rs
.Much of this logic is repeated, but some is chain / environment specific. We can make a generic function, reducing code repetition and making this code more expressive and configurable.
There will likely be more situations in the future where we want to configure genesis state for XCM testing.
We could do something like
Then we could do a
impl RuntimeGenesisConfig for BridgeHubRococoRuntime
, for example.And finally:
Originally suggested here by @liamaharon
The text was updated successfully, but these errors were encountered: