Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow governance body on parachain to have sovereign account #1291

Merged
merged 3 commits into from
Sep 19, 2023
Merged

allow governance body on parachain to have sovereign account #1291

merged 3 commits into from
Sep 19, 2023

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Aug 29, 2023

The goal is to allow Fellowship on Collective chain to have a sovereign account on Polkadot so that we can add it as an identity registrar. This will allow Fellows origin to be able to provide judgements for Fellowship members.

This currently allow any body on any parachain including non system parachains to have sovereign account. I cannot think of any reason why that may be an issue but let me know if I should change it to filter only system parachains.

This is the testing script.

Original PR: paritytech/polkadot#7518

@bkchr bkchr added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Aug 30, 2023
@xlc
Copy link
Contributor Author

xlc commented Sep 14, 2023

Anyone want to hit the merge button? It won't kill you.

@xlc xlc requested a review from a team as a code owner September 14, 2023 02:38
@KiChjang
Copy link
Contributor

This still requires an audit before we can merge/release.

@xlc
Copy link
Contributor Author

xlc commented Sep 16, 2023

This still requires an audit before we can merge/release.

ok. that’s fine. is there a label to indicate that?

@KiChjang
Copy link
Contributor

Not that I know of; someone from devops should look into this, perhaps @the-right-joyce?

@the-right-joyce
Copy link
Contributor

labels are not any longer used for the auditing process. Instead PRs should be added to the security audit board as mentioned here

I see that your PR was archived though, will check with SRLabs and come back to you

@xlc xlc mentioned this pull request Sep 19, 2023
Merged
@the-right-joyce
Copy link
Contributor

@KiChjang it was already audited, we can merge

@KiChjang KiChjang merged commit cdbdbc7 into paritytech:master Sep 19, 2023
6 of 7 checks passed
@xlc xlc deleted the body-sovereign-account branch September 19, 2023 19:57
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
@ggwpez ggwpez mentioned this pull request Jan 30, 2024
Merged
ggwpez
ggwpez reviewed Jan 30, 2024
View reviewed changes
polkadot/runtime/polkadot/src/xcm_config.rs
@@ -68,6 +68,8 @@ pub type SovereignAccountOf = (
ChildParachainConvertsVia<ParaId, AccountId>,
// We can directly alias an `AccountId32` into a local account.
AccountId32Aliases<ThisNetwork, AccountId>,
// Allow governance body to be used as a sovereign account.
HashedDescription<AccountId, DescribeFamily<DescribeBodyTerminal>>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustermeiszer here

@ggwpez ggwpez mentioned this pull request Jan 30, 2024
Merged
fellowship-merge-bot bot added a commit to polkadot-fellows/runtimes that referenced this pull request Feb 2, 2024
@ggwpez @fellowship-merge-bot
@bkchr @joepetrowski
Reapply changes since v1.1.0-rc2 import (#172)
9ce1bbb 
We imported the runtimes into this repo at tag
[`v1.1.0-rc2`](https://github.com/paritytech/polkadot-sdk/commits/v1.1.0-rc2/)
but still merged stuff until they got removed in
[#1731](paritytech/polkadot-sdk#1731).
This re-applies all changes in that commit range
[`v1.1.0-rc2..bf90cb0b`](paritytech/polkadot-sdk@v1.1.0-rc2...bf90cb0)
checked in the SDK with
`git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/`. Closes
#112

Most changes got applied as part of
#56, but two were
missing:
- paritytech/polkadot-sdk#1303
- <s>https://github.com/paritytech/polkadot-sdk/pull/1476</s> (reverted)

<s>One [open
Q](#67 (comment))
since there was a difference between
[#1291](paritytech/polkadot-sdk#1291) and
#67.</s>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
cf606eb 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
a2782f4 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
0c2e7d9 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
a54fc88 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
ea0eb4f 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
fa876fd 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
c51da69 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
80eef12 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
c32f5d5 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
7a3411e 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
1ecc518 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Relay balance metrics (paritytech#1291)
8679385 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Relay balance metrics (#1291)
fe34a52 
* relay balance metrics

* convert balance to "main" tokens in balance metrics

* add balances widgets to maintenance dashboard
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez left review comments

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xlc @KiChjang @the-right-joyce @franciscoaguirre @ggwpez @bkchr