Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xcm): support json schema (for CosmWasm VM support) #1454

Merged
merged 7 commits into from
Dec 7, 2023
Merged

feat(xcm): support json schema (for CosmWasm VM support) #1454

merged 7 commits into from
Dec 7, 2023

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Sep 7, 2023 •
edited
Loading

Description

  • What does this PR do? Allows to generate JSON schema for subset of XCM in std builds
  • Why are these changes needed? To support XCM messages in CosmWasm contracts which require Schemars to generate contract clients
  • How were these changes implemented and what do they affect? We will use schema feature flag to build XCM pallet with JSON schema enabled

Checklist

  • My PR includes a detailed description as outlined in the "Description" section above
  • My PR follows the labeling requirements of this project (at minimum one label for T
    required)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • If this PR alters any external APIs or interfaces used by Polkadot, the corresponding Polkadot PR is ready as well
    as the corresponding Cumulus PR (optional)

@ggwpez ggwpez added the T6-XCM This PR/Issue is related to XCM. label Sep 7, 2023
@dzmitry-lahoda
Copy link
Contributor Author

Now I have to binary blob XCM message and make that blob (message, location, all) to be part of CW api (regardless on chain its runs). Ideally should be able to type and send XCM messages directly, it could be done. But as of now some basic types in XCM messages are no CW Shemars paritytech/parity-common#785

@dzmitry-lahoda dzmitry-lahoda requested a review from a team as a code owner September 18, 2023 23:50
@dzmitry-lahoda
Copy link
Contributor Author

really would be awesome to have before

#2535

paritytech/parity-common#804

paritytech/parity-common#801

so can handle this with some tests in contracts

@paritytech-review-bot paritytech-review-bot bot requested a review from a team December 6, 2023 14:28
ggwpez
ggwpez approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I am not part of the XCM team but looks sensible to me)

prdoc/pr_1454.prdoc Show resolved Hide resolved
@bkchr bkchr merged commit 95c3ee1 into paritytech:master Dec 7, 2023
115 of 116 checks passed
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@dzmitry-lahoda
feat(xcm): support json schema (for CosmWasm VM support) (paritytech#…
110e140 
…1454)

# Description

- What does this PR do? Allows to generate JSON schema for subset of XCM
in std builds
- Why are these changes needed? To support XCM messages in CosmWasm
contracts which require Schemars to generate contract clients
- How were these changes implemented and what do they affect? We will
use schema feature flag to build XCM pallet with JSON schema enabled

# Checklist

- [x] My PR includes a detailed description as outlined in the
"Description" section above
- [x] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
of this project (at minimum one label for `T`
  required)
- [x] I have made corresponding changes to the documentation (if
applicable)
- [x] I have added tests that prove my fix is effective or that my
feature works (if applicable)
- [x] If this PR alters any external APIs or interfaces used by
Polkadot, the corresponding Polkadot PR is ready as well
  as the corresponding Cumulus PR (optional)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
accf51f 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
a7b83b3 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
fee23a1 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
4ce77c9 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
290c59c 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
fdd668e 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
e339ac9 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
45ea1c4 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
8c8ecd4 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
766f96b 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
5b9f6b0 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Add missing parts to rialto parachain bridge (part 1) (paritytech#1454)
f797482 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Add missing parts to rialto parachain bridge (part 1) (#1454)
2f9d8e3 
* add proper parameter names to bridge declaration

* associate RialtoParachain token with DOT

* RialtoParachain<>Millau message pallet owners

* fix compilation
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzmitry-lahoda @franciscoaguirre @bkchr @ggwpez