Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CODEOWNERS Part 1 #1472

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Merge CODEOWNERS Part 1 #1472

merged 3 commits into from
Sep 11, 2023

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 8, 2023

This PR merged the previous CODEOWNERS files.

fix #1164

See also #1415

@chevdor chevdor added the R0-silent Changes should not be mentioned in any release notes label Sep 8, 2023
@chevdor chevdor changed the title Merge CODEOWNERS Merge CODEOWNERS Part 1 Sep 8, 2023
@chevdor chevdor mentioned this pull request Sep 8, 2023
@paritytech-ci paritytech-ci requested review from a team September 8, 2023 15:00
@bkchr
Copy link
Member

bkchr commented Sep 9, 2023

@franciscoaguirre I added polkadot-sdk to the xcm team.

@franciscoaguirre
Copy link
Contributor

@bkchr I added the rule to the file, but it's still giving an error.
I think it's because we have only "read" access, we need "write" according to GitHub.

image

@bkchr
Copy link
Member

bkchr commented Sep 9, 2023

@bkchr I added the rule to the file, but it's still giving an error.
I think it's because we have only "read" access, we need "write" according to GitHub.

image

Fixed.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team September 11, 2023 08:38
Co-authored-by: Alexander Samusev <[email protected]>
@bkchr bkchr requested a review from alvicsam September 11, 2023 09:23
@bkchr bkchr merged commit cdf0de6 into master Sep 11, 2023
8 checks passed
@bkchr bkchr deleted the wk-230908-wk-230906-codeowners-simple branch September 11, 2023 09:33
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Merge CODEOWNERS

* Add the XCM team as owner of /polkadot/xcm

* Update .github/CODEOWNERS

Co-authored-by: Alexander Samusev <[email protected]>

---------

Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Alexander Samusev <[email protected]>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
* Merge CODEOWNERS

* Add the XCM team as owner of /polkadot/xcm

* Update .github/CODEOWNERS

Co-authored-by: Alexander Samusev <[email protected]>

---------

Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Alexander Samusev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup: CODEOWNERS file
5 participants