Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align LocationToAccount derivation #1928

Conversation

mustermeiszer
Copy link

In order to allow other chains to have consistent "remote" accounts in other chains, it is needed that all chains in the ecosystem derive accounts in the XCM logic in the same way.

See https://forum.polkadot.network/t/multichain-friendly-account-abstraction/1298/23

This PR aligns all runtimes of system-parachains to have that derivation. It is debatable whether this derivation should also go into the relay-chain runtimes.

@mustermeiszer
Copy link
Author

The formatting changes are due to running rustfmt on the changed files. Not sure, but it seems they are not formatted according to this repos fmt rule in the first place, or my formatter is doing something odly.

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/multichain-friendly-account-abstraction/1298/26

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4004370

@bkontur
Copy link
Contributor

bkontur commented Oct 18, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 18, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4004842 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-d6d1a0b3-7dfb-4e37-b191-e1b3cd90f783 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 18, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4004842 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4004842/artifacts/download.

@bkontur
Copy link
Contributor

bkontur commented Oct 18, 2023

@mustermeiszer for Kusama/Polkadot relaychain+system parachain runtimes you should open PR here

@paritytech-ci paritytech-ci requested review from a team October 18, 2023 14:37
@mustermeiszer
Copy link
Author

Closing in favor of polkadot-fellows/runtimes#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants