Elliptic curves utilities refactory #2068
Conversation
davxy
requested review from
andresilva,
koute,
michalkucharczyk,
skunert,
bkchr,
a team,
dmitry-markin and
altonen
So these crates here are just a verbatim copy? |
| //! Elliptic curves which are mostly compatible with *Arkworks* library | ||
| //! mostly useful in non-native contexts. |
There was a problem hiding this comment.
maybe?
| //! Elliptic curves which are mostly compatible with *Arkworks* library | |
| //! mostly useful in non-native contexts. | |
| //! This crate offers elliptic curves functionality which is mostly compatible with *Arkworks* library. | |
| //! It is primarily designed for use in non-native contexts. |
also wouid be nice to have link to Arkworks.
| //! The definitions make use of host functions to offload the non-native | ||
| //! computational environment from the some of the most computationally | ||
| //! expensive operations by internally leveraging the | ||
| //! [arkworks-extensions](https://github.com/paritytech/arkworks-extensions) | ||
| //! library. |
There was a problem hiding this comment.
| //! The definitions make use of host functions to offload the non-native | |
| //! computational environment from the some of the most computationally | |
| //! expensive operations by internally leveraging the | |
| //! [arkworks-extensions](https://github.com/paritytech/arkworks-extensions) | |
| //! library. | |
| //! The implementation make use of host functions to offload the non-native | |
| //! environment from some of the most computationally | |
| //! expensive operations. It internally leverages the | |
| //! [arkworks-extensions](https://github.com/paritytech/arkworks-extensions) | |
| //! library. |
@bkchr Not really verbatim (but in practice, at the moment, yes). Here we leverage some tiny After this is merged arkworks-substrate will be refactored to just expose (re-export) the stuff we are implementing here (0 logic there). So the crates there will act as some kind of convenience facade. The arkworks-substrate crates are handy if someone wants to include the single crates individually and thus more closely mimics what you'd do when using upstream Arkworks. |
- Usage the new published [arkworks-extensions](https://github.com/paritytech/arkworks-extensions) crates. Hooks are internally defined to jump into the proper host functions. - Conditional compilation of each curve (gated by feature with curve name) - Separation in smaller host functions sets, divided by curve (fits nicely with prev point)
Hooks are internally defined to jump into the proper host functions.
Runtime dev should not care that much about host functions and hooks as these are internally defined and he
can use the library as it'd use Arkworks upstream in his runtimes.
Please be aware that this library is mostly designed for internal usage within crates residing in the
polkadot-sdkworkspace, such as Bandersnatch. This is to avoid potential problems, as demonstrated in issues like #2013.Devs of pallets outside the workspace can utilize this library or the stand alone crates available on
crates.ioand maintained in arkworks-substrate repository if they like.Stand alone crates essentially offer the same functionality as the curve modules found here.