Add feature flag to enable v2 assignments #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scaffold everything, so that we can enable v2 assignments via a node feature bit, once all nodes have upgraded to the new protocol. Implements: #628 Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
alindima
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Thanks for taking the time to implement the suggestion in #2177 (comment) 👍🏻
alindima
reviewed
Nov 23, 2023
Signed-off-by: Alexandru Gheorghe <[email protected]>
alindima
reviewed
Dec 5, 2023
ordian
requested changes
Dec 5, 2023
sandreim
approved these changes
Dec 5, 2023
Signed-off-by: Alexandru Gheorghe <[email protected]>
AndreiEres
approved these changes
Dec 5, 2023
alindima
approved these changes
Dec 5, 2023
alexggh
added
R0-silent
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Gheorghe <[email protected]>
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffold everything, so that we can enable v2 assignments via a node feature bit, once all nodes have upgraded to the new protocol.
Implements: #628