Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes parsing for config attrs in pallet macros #2677

Merged
merged 16 commits into from
Dec 13, 2023
Merged

Fixes parsing for config attrs in pallet macros #2677

merged 16 commits into from
Dec 13, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Dec 11, 2023 •
edited
Loading

Fixes #2646

  • pallet::call
  • pallet::error
  • derive_impl

@gupnik gupnik added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Dec 11, 2023
@gupnik
Copy link
Contributor Author

gupnik commented Dec 12, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 12, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4690499 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-98ba64cf-e613-4561-a8ce-347bbbbbc5f2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 12, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4690499 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4690499/artifacts/download.

@gupnik gupnik marked this pull request as ready for review December 12, 2023 06:27
@gupnik gupnik requested review from a team December 12, 2023 06:27
bkchr
bkchr approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice :P We already have some feature related tests in frame-support-test.

substrate/frame/support/procedural/src/derive_impl.rs Outdated Show resolved Hide resolved
substrate/frame/support/procedural/src/pallet/expand/error.rs Outdated Show resolved Hide resolved
substrate/frame/support/procedural/src/pallet/expand/call.rs Show resolved Hide resolved
substrate/frame/support/procedural/src/derive_impl.rs Outdated Show resolved Hide resolved
@gupnik
Copy link
Contributor Author

gupnik commented Dec 13, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 13, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4704265 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 20-97639e33-c411-4488-9ce6-0e711eafa53c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 13, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4704265 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4704265/artifacts/download.

@gupnik
Copy link
Contributor Author

gupnik commented Dec 13, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 13, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4705066 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-feac474e-ba4b-45df-9c82-dfd4fae2f534 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 13, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4705066 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4705066/artifacts/download.

@gupnik gupnik merged commit bc82eb6 into master Dec 13, 2023
117 of 118 checks passed
@gupnik gupnik deleted the gupnik/cfg-attrs branch December 13, 2023 10:00
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Fixes parsing for config attrs in pallet macros (paritytech#2677)
301db49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpestana gpestana gpestana approved these changes

@bkchr bkchr bkchr approved these changes

@seadanda seadanda seadanda approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[pallet::call] doesn't handle feature gates correctly
5 participants
@gupnik @gpestana @bkchr @seadanda @liamaharon