Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable async backing on all testnet system chains #2949

Merged
merged 55 commits into from
Feb 2, 2024
Merged

Enable async backing on all testnet system chains #2949

merged 55 commits into from
Feb 2, 2024

Commits on Dec 28, 2023

  1. PHASE 1!

    @mrcnski
    mrcnski committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    277268d View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. PHASE 2!

    @mrcnski
    mrcnski committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    8876b0e View commit details
    Browse the repository at this point in the history

  2. PHASE 3!

    @mrcnski
    mrcnski committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d386c02 View commit details
    Browse the repository at this point in the history

  3. Fix MAXIMUM_BLOCK_WEIGHT

    @mrcnski
    mrcnski committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    c12c82a View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Parametrize SlotDurations for system parachain tests (because of `moc… 

    …k_open_hrmp_channel`) (#2864)

Fixes system parachains unit-tests for
#2826.

---------

Co-authored-by: command-bot <>
    @bkontur
    bkontur committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f1b811d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Add start_asset_hub_lookahead_node

    @mrcnski
    mrcnski committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5350101 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/mrcnski/async-backi… 

    …ng-on-asset-hub-rococo' into mrcnski/async-backing-on-asset-hub-rococo
    @mrcnski
    mrcnski committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c07d887 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Address a couple comments, remove some TODOs

    @mrcnski
    mrcnski committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    1f07f6a View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Add CollationGenerationMessage::Reinitialize

    @mrcnski
    mrcnski committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e7b57b8 View commit details
    Browse the repository at this point in the history

  2. Fix CI

    @mrcnski
    mrcnski committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    1ee2ced View commit details
    Browse the repository at this point in the history

  3. Add prdoc

    @mrcnski
    mrcnski committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    25073e9 View commit details
    Browse the repository at this point in the history

  4. Fix CI (for real)

    @mrcnski
    mrcnski committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    bc48f64 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'master' into mrcnski/async-backing-on-asset-hub-rococo

    @mrcnski
    mrcnski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d4894cf View commit details
    Browse the repository at this point in the history

  2. [WIP]

    @mrcnski
    mrcnski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ed50660 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'mrcnski/async-backing-on-asset-hub-rococo' into mrcnski… 

    …/enable-async-backing-on-testnet-system-chains
    @mrcnski
    mrcnski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    fbd58e4 View commit details
    Browse the repository at this point in the history

  4. Fix CI (again)

    @mrcnski
    mrcnski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0672994 View commit details
    Browse the repository at this point in the history

  5. Enable async backing on all testnet system chains

    @mrcnski
    mrcnski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ff9538f View commit details
    Browse the repository at this point in the history

  6. Enable async backing on contracts-rococo

    @mrcnski
    mrcnski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    23bb3bc View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Fix CI

    @mrcnski
    mrcnski committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7b0ec8b View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Introduce BlockWeightsForAsyncBacking and `MAXIMUM_BLOCK_WEIGHT_FOR… 

    …_ASYNC_BACKING` to bridges primitives (#2966)

Fixes:
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4943591
    @bkontur
    bkontur committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    42f5d1b View commit details
    Browse the repository at this point in the history

  2. Update polkadot/node/subsystem-types/src/messages.rs 

    Co-authored-by: Dónal Murray <[email protected]>
    @mrcnski @seadanda
    mrcnski and seadanda committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c6e85bd View commit details
    Browse the repository at this point in the history

  3. Update cumulus/polkadot-parachain/src/service.rs 

    Co-authored-by: Dónal Murray <[email protected]>
    @mrcnski @seadanda
    mrcnski and seadanda committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6b767f0 View commit details
    Browse the repository at this point in the history

  4. Update cumulus/polkadot-parachain/src/command.rs 

    Co-authored-by: Dónal Murray <[email protected]>
    @mrcnski @seadanda
    mrcnski and seadanda committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    57442d7 View commit details
    Browse the repository at this point in the history

  5. Remove some pub exports

    @mrcnski
    mrcnski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f5cd6fa View commit details
    Browse the repository at this point in the history

  6. Fix CI (definitely for real)

    @mrcnski
    mrcnski committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    eb79b66 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Fix re-exports

    @mrcnski
    mrcnski committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    deea060 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrcnski/async-backing-on-asset-hub-rococo

    @mrcnski
    mrcnski committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3388f5f View commit details
    Browse the repository at this point in the history

  3. fmt

    @mrcnski
    mrcnski committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9ff3316 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Merge branch 'master' into mrcnski/async-backing-on-asset-hub-rococo

    @mrcnski
    mrcnski committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    8f79188 View commit details
    Browse the repository at this point in the history

  2. Bump BLOCK_PROCESSING_VELOCITY

    @mrcnski
    mrcnski committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    359968b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'mrcnski/async-backing-on-asset-hub-rococo' into mrcnski… 

    …/enable-async-backing-on-testnet-system-chains
    @mrcnski
    mrcnski committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a34c909 View commit details
    Browse the repository at this point in the history

  4. Fix compile errors after merge

    @mrcnski
    mrcnski committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    7591656 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Merge branch 'master' into mrcnski/enable-async-backing-on-testnet-sy… 

    …stem-chains
    @mrcnski
    mrcnski committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9c133d0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrcnski/enable-async-backing-on-testnet-sy… 

    …stem-chains
    @mrcnski
    mrcnski committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1c20f57 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'refs/remotes/origin/mrcnski/enable-asyn… 

    …c-backing-on-testnet-system-chains' into mrcnski/enable-async-backing-on-testnet-system-chains
    @mrcnski
    mrcnski committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    424a19e View commit details
    Browse the repository at this point in the history

  4. Add prdoc!

    @mrcnski
    mrcnski committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b018a38 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Fix velocity constant

    @mrcnski
    mrcnski committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    efe15ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrcnski/enable-async-backing-on-testnet-sy… 

    …stem-chains
    @mrcnski
    mrcnski committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ac8fcb2 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Fix PR description

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    f758b5a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrcnski/enable-async-backing-on-testnet-sy… 

    …stem-chains
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    7ea5306 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'master' into mrcnski/enable-async-backing-on-testnet-sy… 

    …stem-chains
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e1d812f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge remote-tracking branch 'origin/master' into mrcnski/enable-asyn… 

    …c-backing-on-testnet-system-chains
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    077e377 View commit details
    Browse the repository at this point in the history

  2. Move constants to, well, constants

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6de532d View commit details
    Browse the repository at this point in the history

  3. Remove stale comment

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7834080 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into mrcnski/enable-asyn… 

    …c-backing-on-testnet-system-chains
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0bc314f View commit details
    Browse the repository at this point in the history

  5. add missing doc

    @svyatonik
    svyatonik committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a12ee76 View commit details
    Browse the repository at this point in the history

  6. Remove stale code

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f2dba7a View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/mrcnski/enable-async-backing-on-… 

    …testnet-system-chains' into mrcnski/enable-async-backing-on-testnet-system-chains
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f5c060d View commit details
    Browse the repository at this point in the history

  8. Move time constants

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    71aef4a View commit details
    Browse the repository at this point in the history

  9. Fix tests

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    771602e View commit details
    Browse the repository at this point in the history

  10. Fix feature propagation

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9de5256 View commit details
    Browse the repository at this point in the history

  11. Fix benchmarking?

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ab0097b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Fix coretime smoke test

    @bkchr
    bkchr committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    5db7a7e View commit details
    Browse the repository at this point in the history

  2. Ensure we return from the script

    @bkchr
    bkchr committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    42ac088 View commit details
    Browse the repository at this point in the history

  3. Fix new_session benchmark in pallet_collator_selection (#3189) 

    Issue was discovered by enabling async backing on all parachains in
[this PR](#2949).

The reason it happened is because with the move to async backing, the
`DAYS` and `HOURS` constants doubled compared to the [previously
imported values from
parachain_common](https://github.com/paritytech/polkadot-sdk/blob/5ba8921787609dddbabb8be3443186b65fdde190/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs#L78),
which led to the
[`Period`](https://github.com/paritytech/polkadot-sdk/blob/5db7a7e1438f518714a7b41793ed6eb01f5668f7/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs#L703)
doubling. This matters because in `pallet_collator_selection::Config`,
the [allowed period of inactivity for collators is a
`Period`](https://github.com/paritytech/polkadot-sdk/blob/5db7a7e1438f518714a7b41793ed6eb01f5668f7/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs#L752).
When a new session is initialized, candidates which don't meet the
criteria
[here](https://github.com/paritytech/polkadot-sdk/blob/5db7a7e1438f518714a7b41793ed6eb01f5668f7/cumulus/pallets/collator-selection/src/lib.rs#L868)
are removed.

The benchmark code
[hardcoded](https://github.com/paritytech/polkadot-sdk/blob/5ba8921787609dddbabb8be3443186b65fdde190/cumulus/pallets/collator-selection/src/benchmarking.rs#L397)
the last active block value which is safe from kick to the pervious
value of a period, `1800`, with the chain starting at `0`. When running
the check, `KickThreshold` was `1800`, so it would pass, but it
obviously doesn't work if the `Period` isn't `1800`.

This PR fixes the benchmark by setting the `new_block` value to
`T::KickThreshold::get()`, which will work for any chosen `Period`.

Opening this PR against the original branch to expedite the merge.

Signed-off-by: georgepisaltu <[email protected]>
    @georgepisaltu
    georgepisaltu committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8bf9c79 View commit details
    Browse the repository at this point in the history