do not block finality for "disabled" disputes #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
changed the title
ordian
added
T8-polkadot
2 tasks
eskimor
reviewed
Feb 16, 2024
| @@ -2968,17 +2981,23 @@ fn participation_with_offchain_disabling() { | |||
| // let's disable validators 3, 4 on chain, but this should not affect this import | |||
| let disabled_validators = vec![ValidatorIndex(3), ValidatorIndex(4)]; | |||
| handle_disabled_validators_queries(&mut virtual_overseer, disabled_validators).await; | |||
There was a problem hiding this comment.
I am confused. We are disabling validators 3 and 4, but the votes are coming from 1 and 2? Ok, so this should not affect the import, make sense, but why should it affect participation further down?
|
The CI pipeline was cancelled due to failure one of the required jobs. |
eskimor
approved these changes
Feb 16, 2024
tdimitrov
approved these changes
Feb 16, 2024
2 tasks
rphmeier
reviewed
Feb 16, 2024
kianenigma
reviewed
Feb 16, 2024
Co-authored-by: Kian Paimani <[email protected]>
eskimor
pushed a commit
that referenced
this pull request
Feb 19, 2024
- [x] test with zombienet-sdk - [x] prdoc Relevant Issues: #3314 (connected to the cause) #3345 (solves) --------- Co-authored-by: Kian Paimani <[email protected]>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 19, 2024
Backport for 1.7: #3358 Relevant Issues: #3314 (connected to the cause) #3345 (solves) --------- --------- Co-authored-by: ordian <[email protected]> Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: eskimor <[email protected]>
ordian
added a commit
that referenced
this pull request
Feb 19, 2024
* master: (41 commits) Add Coretime to Westend (#3319) removed `pallet::getter` from `pallet-sudo` (#3370) gossip-support: add unittests for update authorities (#3258) [FRAME Core] remove unnecessary overrides while using derive_impl for frame_system (#3317) Update coretime-westend bootnodes (#3380) `im-online` removal cleanup: remove off-chain storage (#2290) Bump the known_good_semver group with 1 update (#3379) Fix documentation dead link (#3372) Make `sp-keystore` `no_std`-compatible and fix the `build-runtimes-polkavm` CI job (#3363) Remove unused `im-online` weights (#3373) Ensure referenda `TracksInfo` is sorted (#3325) rpc server: add rate limiting middleware (#3301) do not block finality for "disabled" disputes (#3358) fix(zombienet): docker `img` version to use in merge queues for bridges (#3337) Various nits and alignments for SP testnets found during bumping `polkadot-fellows` repo (#3359) Add broker pallet to `coretime-westend` (#3272) remove recursion limit (#3348) Update subkey README.md (#3355) Bump the known_good_semver group with 6 updates (#3347) Document LocalKeystore insert method (#3336) ...
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/finality-stall-on-kusama-15-02-2024-post-mortem/6398/1 |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues:
#3314 (connected to the cause)
#3345 (solves)