Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to concurrently fetch child keys for remote externality tests #3367

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

brunopgalvao
Copy link
Contributor

@brunopgalvao brunopgalvao commented Feb 17, 2024

Closes #2245

Child-tree data is currently fetched sequentially.

Most chains to date don't have that many child-trees so this hasn't been an issue, but the Rococo Contracts chain has almost 3000 child tries making this serial approach unnecessarily add a really long time to scraping keys.

This PR makes it so requests for child keys are concurrent rather than sequential.

You can test as follows:

TEST_WS=wss://rococo-try-runtime-node.parity-chains.parity.io:443 cargo test --features=remote-test -p frame-remote-externalities -- --nocapture

@brunopgalvao brunopgalvao marked this pull request as ready for review February 17, 2024 07:59
@brunopgalvao
Copy link
Contributor Author

The work here is complete from my end. Please review @liamaharon 🙏🏻 and let me know if any thing else is needed.

Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting @brunopgalvao!

I'd be curious to see a before/after benchmark of scraping the rococo contracts chain with this code.

Will do a proper review next week.

@liamaharon liamaharon added the T0-node This PR/Issue is related to the topic “node”. label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[remote-externalities] Batch calls scraping child-tree data
2 participants