Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate scheduler traits v1 and v2 #3718

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Deprecate scheduler traits v1 and v2 #3718

merged 10 commits into from
Mar 28, 2024

Conversation

chungquantin
Copy link
Contributor

@chungquantin chungquantin commented Mar 17, 2024 •
edited
Loading

This PR add #[deprecated] attribute to v1 and v2 of the schedule trait. Proposed in this issue: #3676

#[allow(deprecated)]
#[deprecated = "traits::schedule::v1 is deprecated. Please use v3 instead."]
pub mod v1 {
...
}

#[allow(deprecated)]
#[deprecated = "traits::schedule::v2 is deprecated. Please use v3 instead."]
pub mod v2 {
...
}

polkadot address: 19nSqFQorfF2HxD3oBzWM3oCh4SaCRKWt1yvmgaPYGCo71J

@chungquantin chungquantin requested a review from a team as a code owner March 17, 2024 03:40
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 17, 2024

User @chungquantin, please sign the CLA here.

@ggwpez ggwpez enabled auto-merge March 17, 2024 12:32
@ggwpez ggwpez disabled auto-merge March 17, 2024 12:52
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 17, 2024 13:53
@chungquantin
Copy link
Contributor Author

@ggwpez resolved to follow the convention.

@ggwpez
Copy link
Member

ggwpez commented Mar 17, 2024 •
edited
Loading

Yes now please put the allow(deprecated) onto the parts that actually need it, like pallet-scheduler.
CI should show it.

@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Mar 17, 2024
@ggwpez ggwpez changed the title Add deprecated tag to schedule trait v1 and v2 Deprecate scheduler traits v1 and v2 Mar 17, 2024
ggwpez
ggwpez reviewed Mar 17, 2024
View reviewed changes
substrate/frame/support/src/traits/schedule.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/traits/schedule.rs Outdated Show resolved Hide resolved
substrate/frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
chungquantin and others added 2 commits March 18, 2024 10:12
@chungquantin @ggwpez
Update deprecated note
54cd332 
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@chungquantin @ggwpez
Update deprecated note
d4e5ef7 
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 18, 2024 03:13
@chungquantin @ggwpez
Remove v3 migration TODO
2c2bebf 
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@chungquantin
Copy link
Contributor Author

@ggwpez I have updated the prdoc, could you help me to review again?

@ggwpez
Copy link
Member

ggwpez commented Mar 19, 2024

Yea LGTM, but it needs reviews from other ppl as well. Dont know where you could best ask, maybe in the fellowship public channel: https://matrix.to/#/#fellowship-open-channel:parity.io

Normally i would ping it internally to colleagues, but that does not scale well.

@liamaharon
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@chungquantin Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

@liamaharon
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@liamaharon A referendum for a small (20 DOT) tip was successfully submitted for @chungquantin (19nSqFQorfF2HxD3oBzWM3oCh4SaCRKWt1yvmgaPYGCo71J on polkadot).

Referendum number: 622.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

@liamaharon liamaharon added this pull request to the merge queue Mar 28, 2024
Merged via the queue into paritytech:master with commit daf04f0 Mar 28, 2024
130 of 132 checks passed
@chungquantin chungquantin deleted the chugnquantin/deprecated_schedule_trait branch March 28, 2024 09:51
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@chungquantin @ggwpez
@liamaharon @dharjeezy
Deprecate scheduler traits v1 and v2 (paritytech#3718)
3569f0a 
This PR add `#[deprecated]` attribute to v1 and v2 of the schedule
trait. Proposed in this issue:
paritytech#3676

```rust
#[allow(deprecated)]
#[deprecated = "traits::schedule::v1 is deprecated. Please use v3 instead."]
pub mod v1 {
...
}

#[allow(deprecated)]
#[deprecated = "traits::schedule::v2 is deprecated. Please use v3 instead."]
pub mod v2 {
...
}
```

polkadot address: 19nSqFQorfF2HxD3oBzWM3oCh4SaCRKWt1yvmgaPYGCo71J

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chungquantin @ggwpez @liamaharon