remove unnessisary use statements due to 2021 core prelude #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Apr 19, 2024
ggwpez
approved these changes
Apr 19, 2024
|
Good spot. There were a few editions set to 2021 but not pointing to the workspace so I've repointed them also. |
bkchr
approved these changes
Apr 21, 2024
muharem
approved these changes
Apr 22, 2024
seadanda
approved these changes
Apr 24, 2024
seadanda
added
the
T1-FRAME
|
@bkontur I need a thumbs-up from the bridges team if you're ok with the changes? |
acatangiu
approved these changes
Apr 28, 2024
Merged
via the queue into
paritytech:master
with commit Apr 28, 2024
954150f
138 of 140 checks passed
Morganamilo
pushed a commit
that referenced
this pull request
May 2, 2024
Some traits are already included in the 2021 prelude and so shouldn't be needed to use explicitly: use `convert::TryFrom`, `convert::TryInto`, and `iter::FromIterator` are removed. ( https://doc.rust-lang.org/core/prelude/rust_2021/ ) No breaking changes or change of functionality, so I think no PR doc is needed in this case. (Motivation: Removes some references to `sp-std`)
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…h#4183) Some traits are already included in the 2021 prelude and so shouldn't be needed to use explicitly: use `convert::TryFrom`, `convert::TryInto`, and `iter::FromIterator` are removed. ( https://doc.rust-lang.org/core/prelude/rust_2021/ ) No breaking changes or change of functionality, so I think no PR doc is needed in this case. (Motivation: Removes some references to `sp-std`)
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some traits are already included in the 2021 prelude and so shouldn't be needed to use explicitly:
use
convert::TryFrom,convert::TryInto, anditer::FromIteratorare removed.( https://doc.rust-lang.org/core/prelude/rust_2021/ )
No breaking changes or change of functionality, so I think no PR doc is needed in this case.
(Motivation: Removes some references to
sp-std)