BEEFY: Define basic fisherman #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
R0-silent
Define basic fisherman structure containing 2 methods: - report_equivocation() was just moved from BeefyWorker. - prove_offenders() is an adaptation of the previous logic for generating key ownership proofs that was part of BeefyWorker::report_equivocation() in oreder to make it more generic. It is used by report_equivocation() now and it will be also needed for reporting signed commitment equivocations in the future.
serban300
force-pushed
the
small_fixes_2
branch
from
ad84d54
to
113658d
Compare
serban300
changed the title
acatangiu
approved these changes
Apr 30, 2024
bkontur
approved these changes
Apr 30, 2024
Merged
via the queue into
paritytech:master
with commit Apr 30, 2024
b8593cc
141 of 142 checks passed
|
This is not |
ggwpez
removed
the
R0-silent
Solrry, I didn't know that renamings need to be mentioned in the CHANGELOR/PR doc. I see that 1.12 is already released. So is it worth doing the version bump no, and adding a PR, or is it just something to know in the future ? |
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Related to paritytech#1903 For paritytech#1903 we will need to add a Fisherman struct. This PR: - defines a basic version of `Fisherman` and moves into it the logic that we have now for reporting double voting equivocations - splits the logic for generating the key ownership proofs into a more generic separate method - renames `EquivocationProof` to `DoubleVotingProof` since later we will introduce a new type of equivocation The PR doesn't contain any functional changes
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1903
For #1903 we will need to add a Fisherman struct. This PR:
Fishermanand moves into it the logic that we have now for reporting double voting equivocationsEquivocationProoftoDoubleVotingProofsince later we will introduce a new type of equivocationThe PR doesn't contain any functional changes