Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate field to prdoc #4368

Merged
merged 1 commit into from
May 3, 2024
Merged

Add validate field to prdoc #4368

merged 1 commit into from
May 3, 2024

Conversation

Morganamilo
Copy link
Contributor

No description provided.

@Morganamilo Morganamilo added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes labels May 3, 2024
@bkchr
Copy link
Member

bkchr commented May 3, 2024

Could you give some insights on why we need this?

@Morganamilo
Copy link
Contributor Author

This is so a person can override the semver check if needed. As there will likely be edge cases.

ggwpez
ggwpez approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned it here in the CI section, but we probably also need to add it to the docs here in the repo.

@Morganamilo
Copy link
Contributor Author

Where in the docs should this be added?

@ggwpez
Copy link
Member

ggwpez commented May 3, 2024 •
edited
Loading

Where in the docs should this be added?

Here is probably enough (looks like the none is incorrectly mentioned). Maybe also here, if you think that it would fit.

@Morganamilo
Copy link
Contributor Author

It looks like we did decide on and did add the none option though: #3998 (comment)

@ggwpez
Copy link
Member

ggwpez commented May 3, 2024

It looks like we did decide on and did add the none option though: #3998 (comment)

🙃 🤦‍♂️ oh, yea. Got confused since we reverted something related to that.
Does make sense now that i read the comment again.

@Morganamilo
Copy link
Contributor Author

Okay seems as the forum post is external I'll merge this PR as is.

@Morganamilo Morganamilo added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit f45847b May 3, 2024
152 of 158 checks passed
@Morganamilo Morganamilo deleted the morganamilo/prdoc-val branch May 3, 2024 16:10
dcolley added a commit to metaspan/polkadot-sdk that referenced this pull request May 6, 2024
@dcolley
Merge branch 'master' of https://github.com/metaspan/polkadot-sdk
5db2d43 
* 'master' of https://github.com/metaspan/polkadot-sdk: (65 commits)
  Introduces `TypeWithDefault<T, D: Get<T>>` (paritytech#4034)
  Publish `polkadot-sdk-frame`  crate (paritytech#4370)
  Add validate field to prdoc (paritytech#4368)
  State trie migration on asset-hub westend and collectives westend (paritytech#4185)
  Fix: dust unbonded for zero existential deposit (paritytech#4364)
  Bridge: added subcommand to relay single parachain header (paritytech#4365)
  Bridge: fix zombienet tests (paritytech#4367)
  [WIP][CI] Add more GHA jobs (paritytech#4270)
  Allow for 0 existential deposit in benchmarks for `pallet_staking`, `pallet_session`, and `pallet_balances` (paritytech#4346)
  Deprecate `NativeElseWasmExecutor` (paritytech#4329)
  More `xcm::v4` cleanup and `xcm_fee_payment_runtime_api::XcmPaymentApi` nits (paritytech#4355)
  sc-tracing: enable env-filter feature (paritytech#4357)
  deps: update jsonrpsee to v0.22.5 (paritytech#4330)
  Add PoV-reclaim enablement guide to polkadot-sdk-docs (paritytech#4244)
  cargo: Update experimental litep2p to latest version (paritytech#4344)
  Bridge: ignore client errors when calling recently added `*_free_headers_interval` methods (paritytech#4350)
  Make parachain template great again (and async backing ready) (paritytech#4295)
  [Backport] Version bumps and reorg prdocs from 1.11.0 (paritytech#4336)
  HRMP - set `DefaultChannelSizeAndCapacityWithSystem` with dynamic values according to the `ActiveConfig` (paritytech#4332)
  Statement Distribution Per Peer Rate Limit (paritytech#3444)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@Morganamilo @TarekkMA
Add validate field to prdoc (paritytech#4368)
af2eed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@ggwpez ggwpez ggwpez approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Morganamilo @bkchr @ggwpez @EgorPopelyaev @liamaharon