Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: added force_set_pallet_state call to pallet-bridge-grandpa #4465

Merged
merged 7 commits into from
May 21, 2024

Conversation

svyatonik
Copy link
Contributor

closes paritytech/parity-bridges-common#2963

See issue above for rationale
I've been thinking about adding similar calls to other pallets, but:

  • for parachains pallet I haven't been able to think of a case when we will need that given how long referendum takes. I.e. if storage proof format changes and we want to unstuck the bridge, it'll take a large a few weeks to sync a single parachain header, then another weeks for another and etc.
  • for messages pallet I've made the similar call initially, but it just changes a storage key (OutboundLanes and/or InboundLanes), so there's no any logic here and it may be simply done using system.set_storage.

@svyatonik svyatonik added the T15-bridges This PR/Issue is related to bridges. label May 15, 2024
@svyatonik svyatonik requested a review from a team May 15, 2024 10:34
@svyatonik
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented May 17, 2024

Here's a link to docs

@svyatonik
Copy link
Contributor Author

bot bench cumulus-bridge-hubs --pallet=pallet_bridge_grandpa

@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230626 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-c153d85b-1eb2-4dd6-bc74-2ddf10e6b6a1 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230626 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230626/artifacts/download.

@svyatonik
Copy link
Contributor Author

bot cancel

@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik No task is being executed for this pull request

@svyatonik
Copy link
Contributor Author

bot bench cumulus-bridge-hubs --pallet=pallet_bridge_grandpa

@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6231075 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-18971453-3eaa-4788-9e35-23df4ad59a22 to cancel this command or bot cancel to cancel all commands in this pull request.

…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6231075 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6231075/artifacts/download.

@svyatonik
Copy link
Contributor Author

bot bench cumulus-bridge-hubs --runtime=bridge-hub-westend --pallet=pallet_bridge_grandpa

@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6237037 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-e08b3655-0a0c-4864-914d-2d04ffc7e7c7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot added 2 commits May 17, 2024 12:05
…=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
@command-bot
Copy link

command-bot bot commented May 17, 2024

@svyatonik Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6237037 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6237037/artifacts/download.

@svyatonik svyatonik enabled auto-merge May 17, 2024 13:28
@svyatonik svyatonik added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@svyatonik svyatonik added this pull request to the merge queue May 21, 2024
@svyatonik svyatonik removed this pull request from the merge queue due to a manual request May 21, 2024
@svyatonik svyatonik added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit e0e1f2d May 21, 2024
150 checks passed
@svyatonik svyatonik deleted the sv-add-force-set-state-calls-to-bridge-pallets branch May 21, 2024 14:18
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…aritytech#4465)

closes paritytech/parity-bridges-common#2963

See issue above for rationale
I've been thinking about adding similar calls to other pallets, but:
- for parachains pallet I haven't been able to think of a case when we
will need that given how long referendum takes. I.e. if storage proof
format changes and we want to unstuck the bridge, it'll take a large a
few weeks to sync a single parachain header, then another weeks for
another and etc.
- for messages pallet I've made the similar call initially, but it just
changes a storage key (`OutboundLanes` and/or `InboundLanes`), so
there's no any logic here and it may be simply done using
`system.set_storage`.

---------

Co-authored-by: command-bot <>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…aritytech#4465)

closes paritytech/parity-bridges-common#2963

See issue above for rationale
I've been thinking about adding similar calls to other pallets, but:
- for parachains pallet I haven't been able to think of a case when we
will need that given how long referendum takes. I.e. if storage proof
format changes and we want to unstuck the bridge, it'll take a large a
few weeks to sync a single parachain header, then another weeks for
another and etc.
- for messages pallet I've made the similar call initially, but it just
changes a storage key (`OutboundLanes` and/or `InboundLanes`), so
there's no any logic here and it may be simply done using
`system.set_storage`.

---------

Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add force_import calls to the pallets
3 participants