Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Upgrade litep2p to v0.6.2 #4799

Merged
merged 16 commits into from
Jun 26, 2024
Merged

network: Upgrade litep2p to v0.6.2 #4799

merged 16 commits into from
Jun 26, 2024

Conversation

dmitry-markin
Copy link
Contributor

This PR upgrades litep2p to the latest version and includes the two fixes:

  1. Enables incoming DHT record validation with litep2p network backend.
  2. Sets TCP_NODELAY flag on TCP & WS sockets in litep2p backend, as it is currently done in libp2p backend.

@dmitry-markin dmitry-markin added A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix T0-node This PR/Issue is related to the topic “node”. dependencies Pull requests that update a dependency file labels Jun 14, 2024
@dmitry-markin dmitry-markin self-assigned this Jun 14, 2024
@dmitry-markin dmitry-markin removed the dependencies Pull requests that update a dependency file label Jun 14, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6477362

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@dmitry-markin
Copy link
Contributor Author

I'm running a burn-in for this PR, if everything looks good over 1-2 day period, we can merge it.

@dmitry-markin
Copy link
Contributor Author

Blocked by paritytech/litep2p#162.

@dmitry-markin dmitry-markin changed the title network: Upgrade litep2p to v0.6.0 network: Upgrade litep2p to v0.6.1 Jun 25, 2024
@dmitry-markin dmitry-markin changed the title network: Upgrade litep2p to v0.6.1 network: Upgrade litep2p to v0.6.2 Jun 26, 2024
@dmitry-markin dmitry-markin added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 4a7155e Jun 26, 2024
153 of 158 checks passed
@dmitry-markin dmitry-markin deleted the dm-upgrade-litep2p branch June 26, 2024 17:12
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
This PR upgrades `litep2p` to the latest version and includes the two
fixes:

1. Enables incoming DHT record validation with `litep2p` network
backend.
2. Sets `TCP_NODELAY` flag on TCP & WS sockets in `litep2p` backend, as
it is currently done in `libp2p` backend.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

6 participants